File tree Expand file tree Collapse file tree 3 files changed +4
-6
lines changed Expand file tree Collapse file tree 3 files changed +4
-6
lines changed Original file line number Diff line number Diff line change @@ -316,7 +316,7 @@ def create(
316316 evaluation_model_taxonomy_metadata = ModelTaxonomyMetadata ()
317317 evaluation_model_taxonomy_metadata [
318318 MetadataTaxonomyKeys .HYPERPARAMETERS
319- ].value = {"model_params" : { dict (asdict (evaluation_model_parameters ))} }
319+ ].value = {"model_params" : dict (asdict (evaluation_model_parameters ))}
320320
321321 evaluation_model = (
322322 DataScienceModel ()
@@ -1192,7 +1192,7 @@ def _delete_job_and_model(job, model):
11921192 f"Exception message: { ex } "
11931193 )
11941194
1195- def load_evaluation_config (self ):
1195+ def load_evaluation_config (self , eval_id ):
11961196 """Loads evaluation config."""
11971197 return {
11981198 "model_params" : {
Original file line number Diff line number Diff line change @@ -120,7 +120,7 @@ class AquaEvaluationConfigHandler(AquaAPIhandler):
120120 def get (self , model_id ):
121121 """Handle GET request."""
122122
123- return self .finish (AquaEvaluationApp ().load_evaluation_config ())
123+ return self .finish (AquaEvaluationApp ().load_evaluation_config (model_id ))
124124
125125
126126__handlers__ = [
Original file line number Diff line number Diff line change @@ -894,9 +894,7 @@ def test_load_evaluation_config(self):
894894 from .utils import EvaluationConfigFormat as config_schema
895895 from .utils import check
896896
897- # todo: revisit after updating load_evaluation_config to accept eval_id
898- # response = self.app.load_evaluation_config(eval_id=TestDataset.EVAL_ID)
899- response = self .app .load_evaluation_config ()
897+ response = self .app .load_evaluation_config (eval_id = TestDataset .EVAL_ID )
900898 assert isinstance (response , dict )
901899 assert check (config_schema , response )
902900
You can’t perform that action at this time.
0 commit comments