Updates in EDIT model method (#984)

Author: kumar-shivam-ranjan

ads/aqua/extension/model_handler.py

@@ -164,7 +164,7 @@ def put(self, id):
 
         enable_finetuning = input_data.get("enable_finetuning")
         task = input_data.get("task")
-        return self.finish(
+        self.finish(
             AquaModelApp().edit_registered_model(
                 id, inference_container, enable_finetuning, task
             )

ads/aqua/model/model.py

@@ -408,7 +408,6 @@ def edit_registered_model(self, id, inference_container, enable_finetuning, task
                 custom_metadata_list.remove("modelDescription")
                 if task:
                     freeform_tags.update({Tags.TASK: task})
-
                 updated_custom_metadata_list = [
                     Metadata(**metadata)
                     for metadata in custom_metadata_list.to_dict()["data"]
@@ -417,7 +416,7 @@ def edit_registered_model(self, id, inference_container, enable_finetuning, task
                     custom_metadata_list=updated_custom_metadata_list,
                     freeform_tags=freeform_tags,
                 )
-                return AquaApp().update_model(id, update_model_details).data
+                AquaApp().update_model(id, update_model_details)
         else:
             raise AquaRuntimeError(
                 f"Failed to edit model:{id}. Only registered unverified models can be edited."

tests/unitary/with_extras/aqua/test_model_handler.py

@@ -96,7 +96,7 @@ def test_delete_with_id(self, mock_delete, mock_urlparse):
     @patch.object(AquaModelApp, "list_valid_inference_containers")
     @patch.object(AquaModelApp, "edit_registered_model")
     def test_put(self, mock_edit, mock_inference_container_list):
-        mock_edit.return_value = {"state": "EDITED"}
+        mock_edit.return_value = None
         mock_inference_container_list.return_value = [
             "odsc-vllm-serving",
             "odsc-tgi-serving",
@@ -114,7 +114,7 @@ def test_put(self, mock_edit, mock_inference_container_list):
         ) as mock_finish:
             mock_finish.side_effect = lambda x: x
             result = self.model_handler.put(id="ocid1.datasciencemodel.oc1.iad.xxx")
-            assert result["state"] is "EDITED"
+            assert result is None
             mock_edit.assert_called_once()
             mock_inference_container_list.assert_called_once()