minor changes

Author: najiyacl

ads/feature_store/dataset.py

@@ -527,7 +527,7 @@ def add_models(self, model_details: ModelDetails) -> "Dataset":
         if updated_model_details and updated_model_details.items and model_details:
             for model_id in model_details.items:
                 if model_id not in updated_model_details["items"]:
-                    logger.warning("Model Id" + model_id + " doesnt exist or you do not have the permission")
+                    logger.warning(f"Either model with Id '{model_id}' doesnt exist or unable to validate")
 
     def remove_models(self, model_details: ModelDetails) -> "Dataset":
         """remove model details from the dataset, remove from the existing dataset model id list

ads/model/generic_model.py

@@ -1941,11 +1941,10 @@ def save(
         # variables in case of saving model in context of model version set.
         model_version_set_id = _extract_model_version_set_id(model_version_set)
 
-        # TODO : optional code
         if featurestore_dataset:
             dataset_details = {
-                "feature-dataset-id": featurestore_dataset.id,
-                "feature-dataset-name-": featurestore_dataset.name
+                "dataset-id": featurestore_dataset.id,
+                "dataset-name": featurestore_dataset.name
             }
             self.metadata_custom.add("featurestore.dataset", value=str(dataset_details),
                                      category=MetadataCustomCategory.TRAINING_AND_VALIDATION_DATASETS,
@@ -1982,8 +1981,7 @@ def save(
         # Add the model id to the feature store dataset
         if featurestore_dataset:
             model_details = ModelDetails().with_items([self.model_id])
-            featurestore_dataset.with_model_details(model_details, False)
-            featurestore_dataset.update()
+            featurestore_dataset.add_models(model_details)
 
         return self.model_id