test updated

Author: najiyacl

ads/feature_store/common/utils/utility.py

@@ -12,7 +12,6 @@
 from great_expectations.core import ExpectationSuite
 
 from ads.common.decorator.runtime_dependency import OptionalDependency
-from ads.common.oci_resource import OCIResource, SEARCH_TYPE
 from ads.feature_store.common.utils.feature_schema_mapper import (
     map_spark_type_to_feature_type,
     map_feature_type_to_pandas,

ads/feature_store/dataset.py

@@ -487,7 +487,6 @@ def with_model_details(self, model_details: ModelDetails) -> "Dataset":
         Parameters
         ----------
         model_details: ModelDetails
-        validate: if to validate the model ids
 
         Returns
         -------

tests/integration/feature_store/test_dataset_validations.py

@@ -91,9 +91,8 @@ def test_dataset_model_details(self):
         assert dataset.oci_dataset.id
 
         dataset.materialise()
-        updated_dataset = dataset.add_models(ModelDetails().with_items(["model_ocid"]))
-        updated_dataset.show()
-        assert updated_dataset.model_details is not None
+        updated_dataset = dataset.add_models(ModelDetails().with_items(["model_ocid_invalid"]))
+        assert len(updated_dataset.model_details.get("items")) == 0
         self.clean_up_dataset(dataset)
         self.clean_up_feature_group(fg)
         self.clean_up_entity(entity)