Skip to content

Commit 5a7c57a

Browse files
committed
test data test
1 parent a7f0398 commit 5a7c57a

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

ads/opctl/operator/lowcode/anomaly/model/anomaly_dataset.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ def _ingest_data(self, spec):
3636
self.X_valid_dict = dict()
3737
self.y_valid_dict = dict()
3838
for s_id, df in self.get_dict_by_series().items():
39-
self.X_valid_dict[s_id] = df.drop(spec.target_column, axis=1)
39+
print(df, spec.target_column)
40+
self.X_valid_dict[s_id] = df.drop([spec.target_column], axis=1)
4041
self.y_valid_dict[s_id] = df[spec.target_column]
4142

4243

ads/opctl/operator/lowcode/anomaly/model/base_model.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from ads.opctl import logger
1818

1919
from ..operator_config import AnomalyOperatorConfig, AnomalyOperatorSpec
20-
from .anomaly_dataset import AnomalyDatasets, AnomalyOutput
20+
from .anomaly_dataset import AnomalyDatasets, AnomalyOutput, TestData
2121
from ads.opctl.operator.lowcode.anomaly.const import OutputColumns, SupportedMetrics
2222
from ..const import SupportedModels
2323
from ads.opctl.operator.lowcode.common.utils import (
@@ -69,7 +69,7 @@ def generate_report(self):
6969
test_data = None
7070

7171
if self.spec.test_data:
72-
test_data = TestData(self.spec.test_data)
72+
test_data = TestData(self.spec)
7373
total_metrics, summary_metrics = self._test_data_evaluate_metrics(
7474
anomaly_output, test_data, elapsed_time
7575
)
@@ -170,8 +170,6 @@ def _evaluation_metrics(self, anomaly_output):
170170
def _test_data_evaluate_metrics(self, anomaly_output, test_data, elapsed_time):
171171
total_metrics = pd.DataFrame()
172172
summary_metrics = pd.DataFrame()
173-
if test_data.empty:
174-
return total_metrics, summary_metrics, None
175173

176174
for cat in anomaly_output.list_categories():
177175
output = anomaly_output.category_map[cat][0]
@@ -191,7 +189,7 @@ def _test_data_evaluate_metrics(self, anomaly_output, test_data, elapsed_time):
191189
total_metrics = pd.concat([total_metrics, metrics_df], axis=1)
192190

193191
if total_metrics.empty:
194-
return total_metrics, summary_metrics, data
192+
return total_metrics, summary_metrics
195193

196194
summary_metrics = pd.DataFrame(
197195
{

tests/operators/anomaly/test_anomaly_simple.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ def test_validation(model):
173173

174174
yaml_i = deepcopy(TEMPLATE_YAML)
175175
yaml_i["spec"]["model"] = model
176+
yaml_i["spec"]["target_column"] = "val_1"
176177
yaml_i["spec"]["input_data"]["url"] = input_data
177178
yaml_i["spec"]["validation_data"] = {"url": valid_data}
178179
yaml_i["spec"]["test_data"] = {"url": test_data}

0 commit comments

Comments
 (0)