Addressing review comments

Author: harsh97

ads/feature_store/docs/source/setup_feature_store.rst

@@ -7,12 +7,12 @@ Feature store is being provided by OCI as a stack based offering in user's own t
 :doc:`Setup via Feature Store Marketplace Operator (Recommended) <./user_guides.setup.feature_store_operator>`
 __________________________________________________________
 
-The feature store marketplace operator can be used to setup the feature store api server in an existing OKE cluster while also utilising an existing MySQL database. It will also help setup authentication and authorization using OCI. For more details, see :doc:`Marketplace operator <./user_guides.setup.feature_store_operator>`
+The feature store marketplace operator can be used to setup the feature store api server in an existing OKE cluster while also utilising an existing MySQL database. It will also help setup authentication and authorization using OCI. For more details, see :doc:`Marketplace operator <./user_guides.setup.feature_store_operator>`. Optionally, we can also setup `Feature Store API Gateway stack <https://github.com/oracle-samples/oci-data-science-ai-samples/blob/main/feature_store/README.md>`_ for authentication and authorization.
 
 :doc:`Setup via Helm Charts <./user_guides.setup.helm_chart>`
 _______________________________
 
-We can manually export images to OCIR using Marketplace UI and then deploy the obtained Helm Chart. Optionally, we can also setup Feature Store API Gateway stack for authentication and authorization.
+We can manually export images to OCIR using Marketplace UI and then deploy the obtained Helm Chart. Optionally, we can also setup `Feature Store API Gateway stack <https://github.com/oracle-samples/oci-data-science-ai-samples/blob/main/feature_store/README.md>`_ for authentication and authorization.
 
 .. _Database configuration:
 
@@ -31,7 +31,10 @@ Storing the password in Vault:
 3. (Required) Additional policies for the Feature Store API dynamic group to allow reading the secret from Vault:
     - ``Allow dynamic-group <feature-store-dynamic-group> to use secret-family in tenancy``
 
-Here ``feature-store-dynamic-group`` is the dynamic group corresponding to the instances of the OKE nodepool where the server is deployed. `Dynamic groups <https://docs.oracle.com/en-us/iaas/Content/Identity/Tasks/callingservicesfrominstances.htm#:~:text=Dynamic%20groups%20allow%20you%20to,against%20Oracle%20Cloud%20Infrastructure%20services.>`_
+Here ``feature-store-dynamic-group`` is the dynamic group corresponding to the instances of the OKE nodepool where the server is deployed.
+
+.. seealso::
+    `Dynamic groups <https://docs.oracle.com/en-us/iaas/Content/Identity/Tasks/callingservicesfrominstances.htm#:~:text=Dynamic%20groups%20allow%20you%20to,against%20Oracle%20Cloud%20Infrastructure%20services.>`_
 
 
 .. _Policies:

ads/feature_store/docs/source/user_guides.setup.feature_store_operator.rst

@@ -63,4 +63,4 @@ After the ``feature_store_marketplace.yaml`` is written using the init step abov
 
 .. code-block:: bash
 
-    ads operator run -f feature_store_marketplace.yaml -b marketplace.python
+    ads operator run -f feature_store_marketplace.yaml -b marketplace

ads/opctl/backend/marketplace/helm_helper.py

@@ -133,7 +133,7 @@ def check_helm_pull(helm_chart_url: str, version: str) -> HelmPullStatus:
         logger.debug(stderr)
         return HelmPullStatus.AUTHENTICATION_FAILURE
     else:
-        print(stderr)
+        logger.error(stderr)
         return HelmPullStatus.UNKNOWN_FAILURE
 
 
@@ -150,7 +150,7 @@ def run_helm_login(ocir_repo: str, token: str):
     if result.returncode == 0:
         pass
     else:
-        print(result.stderr)
+        logger.error(result.stderr)
         # TODO: Throw proper exception
         raise Exception()