Doc Update

Author: najiyacl

ads/feature_store/dataset.py

@@ -530,6 +530,7 @@ def add_models(self, model_details: ModelDetails) -> "Dataset":
                 self.with_model_details(ModelDetails().with_items(existing_model_details["items"]))
             else:
                 self.with_model_details(ModelDetails().with_items([]))
+                return self
 
         # self._update_from_oci_dataset_model(self.oci_dataset)
         # updated_model_details = self.model_details

ads/feature_store/docs/source/dataset.rst

@@ -317,3 +317,16 @@ Below is an example of the output.
 
 .. figure:: figures/dataset_lineage.png
   :width: 400
+
+
+Add Model Details
+=================
+
+You can call the ``add_models()`` method of the Dataset instance to add model ids to dataset.
+The ``.add_models()`` method takes the following parameter:
+``ModelDetails()``  with which we can associate model ids.
+
+
+.. code-block:: python3
+
+  dataset.add_models(ModelDetails().with_items([<ocid1.datasciencemodel..<unique_id>]))

ads/feature_store/docs/source/quickstart.rst

@@ -55,8 +55,9 @@ Background reading to understand the concepts of Feature Store and OCI Data Scie
     compartment_id = "ocid1.compartment.<unique_id>"
     metastore_id = "ocid1.datacatalogmetastore.oc1.iad.<unique_id>"
     api_gateway_endpoint = "https://**.{region}.oci.customer-oci.com/20230101"
+    os.environ["OCI_FS_SERVICE_ENDPOINT"] = api_gateway_endpoint
 
-    ads.set_auth(auth="user_principal", client_kwargs={"service_endpoint": api_gateway_endpoint})
+    ads.set_auth(auth="api_key")
 
     # step1: Create feature store
     feature_store_resource = (

tests/integration/feature_store/test_dataset_validations.py

@@ -91,8 +91,8 @@ def test_dataset_model_details(self):
         assert dataset.oci_dataset.id
 
         dataset.materialise()
-        updated_dataset = dataset.add_models(ModelDetails().with_items(["model_ocid_invalid"]))
-        assert len(updated_dataset.model_details.get("items")) == 0
+        dataset.add_models(ModelDetails().with_items(["model_ocid_invalid"]))
+        assert len(dataset.model_details.get("items")) == 0
         self.clean_up_dataset(dataset)
         self.clean_up_feature_group(fg)
         self.clean_up_entity(entity)