Updated pr.

Author: lu-ohai

ads/aqua/evaluation/entities.py

@@ -95,24 +95,14 @@ class AquaEvalReport(Serializable):
     class Config:
         extra = "ignore"
 
-class ModelParams(Serializable):
-    max_tokens: str = ""
-    top_p: str = ""
-    top_k: str = ""
-    temperature: str = ""
-    presence_penalty: Optional[float] = 0.0
-    frequency_penalty: Optional[float] = 0.0
-    stop: Optional[Union[str, List[str]]] = Field(default_factory=list)
-    model: Optional[str] = "odsc-llm"
-
-    class Config:
-        extra = "allow"
-
-class AquaEvalParams(ModelParams):
+class AquaEvalParams(Serializable):
     shape: str = ""
     dataset_path: str = ""
     report_path: str = ""
 
+    class Config:
+        extra = "allow"
+
 class AquaEvalMetric(Serializable):
     key: str
     name: str

tests/unitary/with_extras/aqua/test_evaluation.py

@@ -506,17 +506,9 @@ def test_create_evaluation(
             "lifecycle_state": f"{evaluation_job_run.lifecycle_state}",
             "name": f"{evaluation_model.display_name}",
             "parameters": {
-                "model": "odsc-llm",
                 "dataset_path": "",
-                "frequency_penalty": 0.0,
-                "max_tokens": "",
-                "presence_penalty": 0.0,
                 "report_path": "",
                 "shape": "",
-                "stop": [],
-                "temperature": "",
-                "top_k": "",
-                "top_p": "",
             },
             "source": {
                 "id": "ocid1.datasciencemodel.oc1.iad.<OCID>",