validation output changes

Author: najiyacl

ads/feature_store/dataset.py

@@ -887,11 +887,7 @@ def get_validation_output(self, job_id: str = None) -> "ValidationOutput":
         validation_output = (
             output_details.get("validationOutput") if output_details else None
         )
-        validation_output_json = (
-            json.loads(validation_output) if validation_output else None
-        )
-
-        return ValidationOutput(validation_output_json)
+        return ValidationOutput(validation_output)
 
     @classmethod
     def list_df(cls, compartment_id: str = None, **kwargs) -> "pandas.DataFrame":

ads/feature_store/feature_group.py

@@ -1288,11 +1288,7 @@ def get_validation_output(self, job_id: str = None) -> "ValidationOutput":
             output_details.get("validationOutput") if output_details else None
         )
 
-        validation_output_json = (
-            json.loads(validation_output) if validation_output else None
-        )
-
-        return ValidationOutput(validation_output_json)
+        return ValidationOutput(validation_output)
 
     def __getattr__(self, name):
         try:

ads/feature_store/validation_output.py

@@ -1,3 +1,4 @@
+import json
 import pandas as pd
 from typing import Dict
 from copy import deepcopy
@@ -22,9 +23,29 @@ def to_pandas(self) -> pd.DataFrame:
             The validation output information as a pandas DataFrame.
         """
         if self.content:
-            profile_result = pd.json_normalize(self.content).transpose()
+            validation_output_json = (
+                json.loads(self.content)
+            )
+            profile_result = pd.json_normalize(validation_output_json.get("results")).transpose()
             return profile_result
 
+    def to_summary(self) -> pd.DataFrame:
+        """
+        Converts the validation output summary information to a pandas DataFrame.
+
+        Returns
+        -------
+        pd.DataFrame
+            The validation output summary information as a pandas DataFrame.
+        """
+        if self.content:
+            validation_output_json = (
+                json.loads(self.content)
+            )
+            profile_result = pd.json_normalize(validation_output_json).transpose()
+            summary_df = profile_result.drop("results")
+            return summary_df
+
     @property
     def kind(self) -> str:
         """

tests/integration/feature_store/test_dataset_validations.py

@@ -60,6 +60,11 @@ def test_dataset_validation_operations(self):
         assert "success" in df.columns
         assert True in df["success"].values
 
+        df = dataset.get_validation_output().to_summary().T
+        assert df is not None
+        assert "success" in df.columns
+        assert True in df["success"].values
+
         self.clean_up_dataset(dataset)
         self.clean_up_feature_group(fg)
         self.clean_up_entity(entity)

tests/integration/feature_store/test_feature_group_validations.py

@@ -68,10 +68,17 @@ def test_feature_group_validation_operations_single(self):
 
         assert fg.oci_feature_group.id
         fg.materialise(self.data)
+
         df = fg.get_validation_output().to_pandas().T
         assert df is not None
         assert "success" in df.columns
         assert True in df["success"].values
+
+        df = fg.get_validation_output().to_summary().T
+        assert df is not None
+        assert "success" in df.columns
+        assert True in df["success"].values
+
         self.clean_up_feature_group(fg)
         self.clean_up_entity(entity)
         self.clean_up_feature_store(fs)