use snapshot download return value as local dir

Author: VipulMascarenhas

ads/aqua/model/model.py

@@ -1328,7 +1328,9 @@ def _download_model_from_hf(
         if local_dir:
             local_dir = os.path.join(local_dir, model_name)
             os.makedirs(local_dir, exist_ok=True)
-        snapshot_download(
+
+        # if local_dir is not set, the return value points to the cached data folder
+        local_dir = snapshot_download(
             repo_id=model_name,
             local_dir=local_dir,
             allow_patterns=allow_patterns,

tests/unitary/with_extras/aqua/test_model.py

@@ -743,6 +743,7 @@ def test_import_verified_model(
         app = AquaModelApp()
         if download_from_hf:
             with tempfile.TemporaryDirectory() as tmpdir:
+                mock_snapshot_download.return_value = f"{str(tmpdir)}/{model_name}"
                 model: AquaModel = app.register(
                     model=model_name,
                     os_path=os_path,