Skip to content

Commit 05e35cf

Browse files
authored
Merge branch 'main' into ODSC-74228/GPU-Shape-Recommendation
2 parents 32004b7 + 9652d9c commit 05e35cf

File tree

2 files changed

+22
-11
lines changed

2 files changed

+22
-11
lines changed

ads/aqua/constants.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@
5656
MODEL_BY_REFERENCE_OSS_PATH_KEY = "artifact_location"
5757

5858
AQUA_CHAT_TEMPLATE_METADATA_KEY = "chat_template"
59+
UNKNOWN_ENUM_VALUE = "UNKNOWN_ENUM_VALUE"
60+
MODEL_GROUP = "MODEL_GROUP"
61+
SINGLE_MODEL_FLEX = "SINGLE_MODEL_FLEX"
5962

6063
CONSOLE_LINK_RESOURCE_TYPE_MAPPING = {
6164
"datasciencemodel": "models",

ads/aqua/modeldeployment/deployment.py

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,11 @@
4545
AQUA_MODEL_TYPE_SERVICE,
4646
AQUA_MULTI_MODEL_CONFIG,
4747
MODEL_BY_REFERENCE_OSS_PATH_KEY,
48+
MODEL_GROUP,
4849
MODEL_NAME_DELIMITER,
50+
SINGLE_MODEL_FLEX,
4951
UNKNOWN_DICT,
52+
UNKNOWN_ENUM_VALUE,
5053
)
5154
from ads.aqua.data import AquaResourceIdentifier
5255
from ads.aqua.model import AquaModelApp
@@ -873,21 +876,26 @@ def list(self, **kwargs) -> List["AquaDeployment"]:
873876

874877
if oci_aqua:
875878
# skipping the AQUA model deployments that are created from model group
876-
# TODO: remove this checker after AQUA deployment is integrated with model group
877-
aqua_model_id = model_deployment.freeform_tags.get(
878-
Tags.AQUA_MODEL_ID_TAG, UNKNOWN
879-
)
880879
if (
881-
"datasciencemodelgroup" in aqua_model_id
882-
or model_deployment.model_deployment_configuration_details.deployment_type
883-
== "UNKNOWN_ENUM_VALUE"
880+
model_deployment.model_deployment_configuration_details.deployment_type
881+
in [UNKNOWN_ENUM_VALUE, MODEL_GROUP, SINGLE_MODEL_FLEX]
884882
):
885883
continue
886-
results.append(
887-
AquaDeployment.from_oci_model_deployment(
888-
model_deployment, self.region
884+
try:
885+
results.append(
886+
AquaDeployment.from_oci_model_deployment(
887+
model_deployment, self.region
888+
)
889889
)
890-
)
890+
except Exception as e:
891+
logger.error(
892+
f"There was an issue processing the list of model deployments . Error: {str(e)}",
893+
exc_info=True,
894+
)
895+
raise AquaRuntimeError(
896+
f"There was an issue processing the list of model deployments . Error: {str(e)}"
897+
) from e
898+
891899
# log telemetry if MD is in active or failed state
892900
deployment_id = model_deployment.id
893901
state = model_deployment.lifecycle_state.upper()

0 commit comments

Comments
 (0)