remove config-ready check from forced-decision apis (#442)

Author: jaeopt

Sources/Optimizely+Decide/OptimizelyUserContext.swift

@@ -169,11 +169,6 @@ extension OptimizelyUserContext {
     ///   - decision: A forced decision.
     /// - Returns: true if the forced decision has been set successfully.
     public func setForcedDecision(context: OptimizelyDecisionContext, decision: OptimizelyForcedDecision) -> Bool {
-        guard optimizely?.config != nil else {
-            logger.e(OptimizelyError.sdkNotReady)
-            return false
-        }
-        
         // create on the first setForcedDecision call
 
         if forcedDecisions == nil {
@@ -189,11 +184,6 @@ extension OptimizelyUserContext {
     ///   - context: A decision context
     /// - Returns: A forced decision or nil if forced decisions are not set for the decision context.
     public func getForcedDecision(context: OptimizelyDecisionContext) -> OptimizelyForcedDecision? {
-        guard optimizely?.config != nil else {
-            logger.e(OptimizelyError.sdkNotReady)
-            return nil
-        }
-        
         guard forcedDecisions != nil else { return nil }
 
         return findForcedDecision(context: context)
@@ -204,11 +194,6 @@ extension OptimizelyUserContext {
     ///   - context: A decision context.
     /// - Returns: true if the forced decision has been removed successfully.
     public func removeForcedDecision(context: OptimizelyDecisionContext) -> Bool {
-        guard optimizely?.config != nil else {
-            logger.e(OptimizelyError.sdkNotReady)
-            return false
-        }
-        
         guard let fds = forcedDecisions else { return false }
 
         if findForcedDecision(context: context) != nil {
@@ -222,11 +207,6 @@ extension OptimizelyUserContext {
     /// Removes all forced decisions bound to this user context.
     /// - Returns: true if forced decisions have been removed successfully.
     public func removeAllForcedDecisions() -> Bool {
-        guard optimizely?.config != nil else {
-            logger.e(OptimizelyError.sdkNotReady)
-            return false
-        }
-        
         if let fds = forcedDecisions {
             fds.removeAll()
         }

Tests/OptimizelyTests-Common/OptimizelyUserContextTests_ForcedDecisions.swift

@@ -46,19 +46,6 @@ class OptimizelyUserContextTests_ForcedDecisions: XCTestCase {
         let context = OptimizelyDecisionContext(flagKey: "feature_1")
         let d = OptimizelyForcedDecision(variationKey: "3324490562")
 
-        try? optimizely.start(datafile: "invalid datafile contents")
-
-        status = user.setForcedDecision(context: context, decision: d)
-        XCTAssertFalse(status)
-        result = user.getForcedDecision(context: context)
-        XCTAssertNil(result)
-        status = user.removeForcedDecision(context: context)
-        XCTAssertFalse(status)
-        status = user.removeAllForcedDecisions()
-        XCTAssertFalse(status)
-
-        try? optimizely.start(datafile: datafile)
-
         status = user.setForcedDecision(context: context, decision: d)
         XCTAssertTrue(status)
         result = user.getForcedDecision(context: context)