change start back to initializeSDK (will fix later)

Author: jaeopt

DemoObjCApp/AppDelegate.m

@@ -64,7 +64,7 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
 -(void)initializeOptimizelySDKAsynchronous {
     self.optimizely = [[OptimizelyManager alloc] initWithSdkKey:kOptimizelySdkKey];
 
-    [self.optimizely startWithCompletion:^(NSData *data, NSError *error) {
+    [self.optimizely initializeSDKWithCompletion:^(NSData *data, NSError *error) {
         if (error == nil) {
             NSLog(@"Optimizely SDK initialized successfully!");
         } else {
@@ -93,7 +93,7 @@ -(void)initializeOptimizelySDKSynchronous {
         self.optimizely = nil;
     } else {
         NSError *error;
-        BOOL status = [self.optimizely startWithDatafile:datafileJSON error:&error];
+        BOOL status = [self.optimizely initializeSDKWithDatafile:datafileJSON error:&error];
         if (status) {
             NSLog(@"Optimizely SDK initialized successfully!");
         } else {
@@ -144,7 +144,7 @@ -(void)initializeOptimizelySDKWithCustomization {
 #endif
     }];
 
-    [self.optimizely startWithCompletion:^(NSData *data, NSError *error) {
+    [self.optimizely initializeSDKWithCompletion:^(NSData *data, NSError *error) {
         if (error == nil) {
             NSLog(@"Optimizely SDK initialized successfully!");
         } else {

DemoSwiftApp/AppDelegate.swift

@@ -63,7 +63,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
     func initializeOptimizelySDKAsynchronous() {
         optimizely = OptimizelyManager(sdkKey: sdkKey)
 
-        optimizely.start { result in
+        optimizely.initializeSDK { result in
             switch result {
             case .failure(let error):
                 print("Optimizely SDK initiliazation failed: \(error)")
@@ -87,7 +87,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
         do {
             let datafileJSON = try String(contentsOfFile: localDatafilePath, encoding: .utf8)
-            try optimizely!.start(datafile: datafileJSON)
+            try optimizely!.initializeSDK(datafile: datafileJSON)
             print("Optimizely SDK initialized successfully!")
         } catch {
             print("Optimizely SDK initiliazation failed: \(error)")
@@ -154,7 +154,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 
         // initialize SDK
 
-        optimizely!.start { result in
+        optimizely!.initializeSDK { result in
             switch result {
             case .failure(let error):
                 print("Optimizely SDK initiliazation failed: \(error)")

OptimizelySDK/Optimizely/OptimizelyManager+ObjC.swift

@@ -58,16 +58,16 @@ extension OptimizelyManager {
     }
 
     @available(swift, obsoleted: 1.0)
-    @objc(startWithCompletion:)
+    @objc(initializeSDKWithCompletion:)
     /// Start Optimizely SDK (Asynchronous)
     ///
     /// If an updated datafile is available in the server, it's downloaded and the SDK is configured with
     /// the updated datafile.
     ///
     /// - Parameters:
     ///   - completion: callback when initialization is completed
-    public func _objcStart(completion: ((Data?, NSError?) -> Void)?) {
-        start { result in
+    public func _objcInitializeSDK(completion: ((Data?, NSError?) -> Void)?) {
+        initializeSDK { result in
             switch result {
             case .failure(let error):
                 completion?(nil, self.convertErrorForObjc(error))
@@ -78,19 +78,19 @@ extension OptimizelyManager {
     }
 
     @available(swift, obsoleted: 1.0)
-    @objc(startWithDatafile:error:)
+    @objc(initializeSDKWithDatafile:error:)
     /// Start Optimizely SDK (Synchronous)
     ///
     /// - Parameters:
     ///   - datafile: This datafile will be used when cached copy is not available (fresh start).
     ///             A cached copy from previous download is used if it's available.
     ///             The datafile will be updated from the server in the background thread.
     public func _objcStartWith(datafile:String) throws {
-        try self.start(datafile: datafile)
+        try self.initializeSDK(datafile: datafile)
     }
 
     @available(swift, obsoleted: 1.0)
-    @objc(startWithDatafile:doFetchDatafileBackground:error:)
+    @objc(initializeSDKWithDatafile:doFetchDatafileBackground:error:)
     /// Start Optimizely SDK (Synchronous)
     ///
     /// - Parameters:
@@ -101,7 +101,7 @@ extension OptimizelyManager {
     ///             you don't want to download the datafile.  In practice, you should allow the
     ///             background thread to update the cache copy (optional)
     public func _objcStart(datafile: Data, doFetchDatafileBackground: Bool = true) throws {
-        try self.start(datafile: datafile, doFetchDatafileBackground: doFetchDatafileBackground)
+        try self.initializeSDK(datafile: datafile, doFetchDatafileBackground: doFetchDatafileBackground)
     }
 
     @available(swift, obsoleted: 1.0)

OptimizelySDK/Optimizely/OptimizelyManager.swift

@@ -98,7 +98,7 @@ open class OptimizelyManager: NSObject {
     /// - Parameters:
     ///   - resourceTimeout: timeout for datafile download (optional)
     ///   - completion: callback when initialization is completed
-    public func start(resourceTimeout:Double? = nil, completion: ((OptimizelyResult<Data>) -> Void)?=nil) {
+    public func initializeSDK(resourceTimeout:Double? = nil, completion: ((OptimizelyResult<Data>) -> Void)?=nil) {
         fetchDatafileBackground(resourceTimeout:resourceTimeout) { result in
             switch result {
             case .failure:
@@ -124,12 +124,12 @@ open class OptimizelyManager: NSObject {
     ///   - datafile: This datafile will be used when cached copy is not available (fresh start).
     ///             A cached copy from previous download is used if it's available.
     ///             The datafile will be updated from the server in the background thread.
-    public func start(datafile: String) throws {
+    public func initializeSDK(datafile: String) throws {
         guard let datafileData = datafile.data(using: .utf8) else {
             throw OptimizelyError.dataFileInvalid
         }
 
-        try start(datafile: datafileData)
+        try initializeSDK(datafile: datafileData)
     }
 
     /// Start Optimizely SDK (Synchronous)
@@ -141,7 +141,7 @@ open class OptimizelyManager: NSObject {
     ///   - doFetchDatafileBackground: This is for debugging purposes when
     ///             you don't want to download the datafile.  In practice, you should allow the
     ///             background thread to update the cache copy (optional)
-    public func start(datafile: Data, doFetchDatafileBackground: Bool = true) throws {
+    public func initializeSDK(datafile: Data, doFetchDatafileBackground: Bool = true) throws {
         let cachedDatafile = self.datafileHandler.loadSavedDatafile(sdkKey: self.sdkKey)
 
         let selectedDatafile = cachedDatafile ?? datafile

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests.swift

@@ -25,7 +25,7 @@ class OptimizelyManagerTests: XCTestCase {
         // Put setup code here. This method is called before the invocation of each test method in the class.
         optimizely = OptimizelyManager(sdkKey: "SDKKEY")
 
-       try! optimizely?.start(datafile:json)
+       try! optimizely?.initializeSDK(datafile:json)
     }
 
     override func tearDown() {

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_ForcedVariation.swift

@@ -33,7 +33,7 @@ class OptimizelyManagerTests_ForcedVariation: XCTestCase {
 
         self.optimizely = OptimizelyManager(sdkKey: "12345",
                                             userProfileService: OTUtils.createClearUserProfileService())
-        try! self.optimizely.start(datafile: datafile)
+        try! self.optimizely.initializeSDK(datafile: datafile)
     }
 
     func testForcedVariation_ThenActivate() {
@@ -79,7 +79,7 @@ class OptimizelyManagerTests_ForcedVariation: XCTestCase {
 
         // reload ProjectConfig (whitelist must NOT be sustained)
 
-        try! self.optimizely.start(datafile: datafile)
+        try! self.optimizely.initializeSDK(datafile: datafile)
         variationKey = self.optimizely.getForcedVariation(experimentKey: kExperimentKey, userId: kUserId)
         XCTAssertNil(variationKey)
     }

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_Invalid.swift

@@ -33,7 +33,7 @@ class OptimizelyManagerTests_Invalid: XCTestCase {
         self.optimizely = OptimizelyManager(sdkKey: kSdkKey)
 
         let invalidDatafile = "{\"version\": \"4\"}"
-        try? self.optimizely.start(datafile: invalidDatafile)
+        try? self.optimizely.initializeSDK(datafile: invalidDatafile)
     }
 
     func testActivate_WhenManagerNonInitialized() {

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_ObjcAPIs.m

@@ -104,7 +104,7 @@ - (void)setUp {
 
     self.optimizely = [[OptimizelyManager alloc] initWithSdkKey: kSdkKey];
 
-    [self.optimizely startWithDatafile:fileContents error:nil];
+    [self.optimizely initializeSDKWithDatafile:fileContents error:nil];
 
     self.attributes = @{ @"name": @"tom", @"age": @21 };
 }
@@ -231,11 +231,11 @@ - (void)testCustomizationAPIs {
                                        periodicDownloadInterval:@(50)
                                                  defaultLogLevel:OptimizelyLogLevelInfo];
 
-    [self.optimizely startWithCompletion:^(NSData * _Nullable data, NSError * _Nullable error) {}];
+    [self.optimizely initializeSDKWithCompletion:^(NSData * _Nullable data, NSError * _Nullable error) {}];
 
-    [self.optimizely startWithDatafile:datafile error:nil];
+    [self.optimizely initializeSDKWithDatafile:datafile error:nil];
 
-    [self.optimizely startWithDatafile:datafileData doFetchDatafileBackground:false error:nil];
+    [self.optimizely initializeSDKWithDatafile:datafileData doFetchDatafileBackground:false error:nil];
 }
 
 @end

OptimizelySDK/OptimizelyTests/OptimizelyTests-APIs/OptimizelyManagerTests_Valid.swift

@@ -56,7 +56,7 @@ class OptimizelyManagerTests_Valid: XCTestCase {
 
         self.optimizely = OptimizelyManager(sdkKey: "12345",
                                             userProfileService: OTUtils.createClearUserProfileService())
-        try! self.optimizely.start(datafile: datafile)
+        try! self.optimizely.initializeSDK(datafile: datafile)
     }
 
     func testActivate() {

OptimizelySDK/OptimizelyTests/OptimizelyTests-Common/BatchEventBuilderTest.swift

@@ -30,7 +30,7 @@ class BatchEventBuilderTests: XCTestCase {
 
         let datafile = OTUtils.loadJSONDatafile(datafileName)
         do {
-            try optimizely?.start(datafile: datafile!)
+            try optimizely?.initializeSDK(datafile: datafile!)
         }
         catch {
             print(error)