fix: polling interval type bug (#185)

Author: rashidsp

lib/optimizely/config_manager/http_project_config_manager.rb

@@ -187,7 +187,7 @@ def polling_interval(polling_interval)
 
       # If polling interval is less than minimum allowed interval then set it to default update interval.
 
-      if polling_interval.to_i >= Helpers::Constants::CONFIG_MANAGER['MIN_UPDATE_INTERVAL']
+      if (polling_interval.is_a? Integer) && (polling_interval >= Helpers::Constants::CONFIG_MANAGER['MIN_UPDATE_INTERVAL'])
         @polling_interval = polling_interval
         return
       end
@@ -206,15 +206,18 @@ def get_datafile_url(sdk_key, url, url_template)
       # url_template - String representing template which is filled in with
       #               SDK key to determine URL from which to fetch the datafile.
       # Returns String representing URL to fetch datafile from.
-
-      raise InvalidInputsError, 'Must provide at least one of sdk_key or url.' if sdk_key.nil? && url.nil?
+      if sdk_key.nil? && url.nil?
+        @logger.log(Logger::ERROR, 'Must provide at least one of sdk_key or url.')
+        @error_handler.handle_error(InvalidInputsError)
+      end
 
       unless url
         url_template ||= Helpers::Constants::CONFIG_MANAGER['DATAFILE_URL_TEMPLATE']
         begin
           return (url_template % sdk_key)
         rescue
-          raise InvalidInputsError, "Invalid url_template #{url_template} provided."
+          @logger.log(Logger::ERROR, "Invalid url_template #{url_template} provided.")
+          @error_handler.handle_error(InvalidInputsError)
         end
       end
 

spec/config_manager/http_project_config_manager_spec.rb

@@ -279,14 +279,16 @@
   end
 
   describe '#get_datafile_url' do
-    it 'should raise exception when both sdk key and url are nil' do
-      expect do
-        Optimizely::HTTPProjectConfigManager.new(
-          sdk_key: nil,
-          url: nil
-        )
-      end
-        .to raise_error(Optimizely::InvalidInputsError, 'Must provide at least one of sdk_key or url.')
+    it 'should log an error when both sdk key and url are nil' do
+      expect(error_handler).to receive(:handle_error).once.with(Optimizely::InvalidInputsError)
+
+      Optimizely::HTTPProjectConfigManager.new(
+        sdk_key: nil,
+        url: nil,
+        error_handler: error_handler,
+        logger: spy_logger
+      )
+      expect(spy_logger).to have_received(:log).once.with(Logger::ERROR, 'Must provide at least one of sdk_key or url.')
     end
   end
 end