Send name of event tags instead of id (#35)

Author: onufryk

lib/optimizely/event_builder.rb

@@ -1,5 +1,5 @@
 #
-#    Copyright 2016, Optimizely and contributors
+#    Copyright 2016-2017, Optimizely and contributors
 #
 #    Licensed under the Apache License, Version 2.0 (the "License");
 #    you may not use this file except in compliance with the License.
@@ -173,7 +173,7 @@ def add_event_tags(event_tags)
         next if event_tag_value.nil?
 
         event_feature = {
-          'id' => event_tag_key,
+          'name' => event_tag_key,
           'type' => 'custom',
           'value' => event_tag_value,
           'shouldIndex' => false,

spec/event_builder_spec.rb

@@ -1,5 +1,5 @@
 #
-#    Copyright 2016, Optimizely and contributors
+#    Copyright 2016-2017, Optimizely and contributors
 #
 #    Licensed under the Apache License, Version 2.0 (the "License");
 #    you may not use this file except in compliance with the License.
@@ -130,7 +130,7 @@
     }]
     @expected_conversion_params['eventFeatures'] = [
       {
-        'id' => 'revenue',
+        'name' => 'revenue',
         'type' => 'custom',
         'value' => 4200,
         'shouldIndex' => false
@@ -149,7 +149,7 @@
     @expected_conversion_params['eventMetrics'] = []
     @expected_conversion_params['eventFeatures'] = [
       {
-        'id' => 'revenue',
+        'name' => 'revenue',
         'type' => 'custom',
         'value' => "4200",
         'shouldIndex' => false
@@ -167,7 +167,7 @@
   it 'should create a valid V2 Event when create_conversion_event is called with boolean event tag' do
     @expected_conversion_params['eventFeatures'] = [
       {
-        'id' => 'boolean_tag',
+        'name' => 'boolean_tag',
         'type' => 'custom',
         'value' => false,
         'shouldIndex' => false
@@ -188,7 +188,7 @@
   it 'should create a valid V2 Event when create_conversion_event is called with string event tag' do
     @expected_conversion_params['eventFeatures'] = [
       {
-        'id' => 'string_tag',
+        'name' => 'string_tag',
         'type' => 'custom',
         'value' => 'iamstring',
         'shouldIndex' => false
@@ -208,7 +208,7 @@
   it 'should create a valid V2 Event when create_conversion_event is called with integer event tag' do
     @expected_conversion_params['eventFeatures'] = [
       {
-        'id' => 'integer_tag',
+        'name' => 'integer_tag',
         'type' => 'custom',
         'value' => 42,
         'shouldIndex' => false
@@ -228,7 +228,7 @@
   it 'should create a valid V2 Event when create_conversion_event is called with float event tag' do
     @expected_conversion_params['eventFeatures'] = [
       {
-        'id' => 'float_tag',
+        'name' => 'float_tag',
         'type' => 'custom',
         'value' => 42.01,
         'shouldIndex' => false

spec/project_spec.rb

@@ -1,5 +1,5 @@
 #
-#    Copyright 2016, Optimizely and contributors
+#    Copyright 2016-2017, Optimizely and contributors
 #
 #    Licensed under the Apache License, Version 2.0 (the "License");
 #    you may not use this file except in compliance with the License.
@@ -711,7 +711,7 @@ class InvalidErrorHandler; end
         'eventEntityId' => '111095',
         'eventFeatures' => [
           {
-            'id' => 'revenue',
+            'name' => 'revenue',
             'type' => 'custom',
             'value' => 42,
             'shouldIndex' => false
@@ -808,7 +808,7 @@ class InvalidErrorHandler; end
         'eventName' => 'test_event',
         'eventFeatures' => [
           {
-            'id' => 'revenue',
+            'name' => 'revenue',
             'type' => 'custom',
             'value' => 42,
             'shouldIndex' => false