🖊️ sort feature keys (#91)

Author: oakbani

lib/optimizely.rb

@@ -326,7 +326,7 @@ def get_enabled_features(user_id, attributes = nil)
           attributes
         ) == true
       end
-      enabled_features
+      enabled_features.sort
     end
 
     def get_feature_variable_string(feature_flag_key, variable_key, user_id, attributes = nil)

spec/project_spec.rb

@@ -803,6 +803,31 @@ class InvalidErrorHandler; end
       # Checks prevented features should not return
       expect(project_instance.get_enabled_features('test_user', 'browser_type' => 'chrome')).not_to include(*disabled_features)
     end
+
+    it 'should return sorted feature keys' do
+      # Mock is_feature_enabled and assert that is_feature_enabled does get called in an unsorted order
+      expect(project_instance).to receive(:is_feature_enabled).with('boolean_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+      expect(project_instance).to receive(:is_feature_enabled).with('double_single_variable_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+      expect(project_instance).to receive(:is_feature_enabled).with('integer_single_variable_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+      expect(project_instance).to receive(:is_feature_enabled).with('boolean_single_variable_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+      expect(project_instance).to receive(:is_feature_enabled).with('string_single_variable_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+      expect(project_instance).to receive(:is_feature_enabled).with('multi_variate_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+      expect(project_instance).to receive(:is_feature_enabled).with('mutex_group_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+      expect(project_instance).to receive(:is_feature_enabled).with('empty_feature', 'test_user', 'browser_type' => 'chrome').and_return(true).ordered
+
+      expect(project_instance.get_enabled_features('test_user', 'browser_type' => 'chrome')).to eq(
+        %w[
+          boolean_feature
+          boolean_single_variable_feature
+          double_single_variable_feature
+          empty_feature
+          integer_single_variable_feature
+          multi_variate_feature
+          mutex_group_feature
+          string_single_variable_feature
+        ]
+      )
+    end
   end
 
   describe '#get_feature_variable_string' do