Merge pull request #18 from optimizely/aliabbasrizvi/fail_parse

Setting default values correctly

Author: aliabbasrizvi

src/Optimizely/ProjectConfig.php

@@ -129,11 +129,11 @@ public function __construct($datafile, $logger, $errorHandler)
         $this->_projectId = $config['projectId'];
         $this->_revision = $config['revision'];
 
-        $groups = $config['groups'];
-        $experiments = $config['experiments'];
-        $events = $config['events'];
-        $attributes = $config['attributes'];
-        $audiences = $config['audiences'];
+        $groups = $config['groups'] ?: [];
+        $experiments = $config['experiments'] ?: [];
+        $events = $config['events'] ?: [];
+        $attributes = $config['attributes'] ?: [];
+        $audiences = $config['audiences'] ?: [];
 
         $this->_groupIdMap = ConfigParser::generateMap($groups, 'id', Group::class);
         $this->_experimentKeyMap = ConfigParser::generateMap($experiments, 'key', Experiment::class);

tests/OptimizelyTest.php

@@ -143,8 +143,6 @@ public function testValidateInputsInvalidFileJsonValidationNotSkipped()
             'Random datafile',
             false)
         );
-
-        $this->expectOutputRegex('/Provided "datafile" has invalid schema./');
     }
 
     public function testValidateInputsInvalidFileJsonValidationSkipped()
@@ -156,8 +154,6 @@ public function testValidateInputsInvalidFileJsonValidationSkipped()
             $validateInputsMethod->invoke(new Optimizely('Random datafile', null, null, null, true),
             'Random datafile', true)
         );
-
-        $this->expectOutputRegex('/Provided "datafile" is in an invalid format./');
     }
 
     public function testValidatePreconditionsExperimentNotRunning()