refact: changed getFeatureVariableJson to getFeatureVariableJSON (#202)

Author: oakbani

src/Optimizely/Entity/FeatureVariable.php

@@ -151,7 +151,7 @@ public static function getFeatureVariableMethodName($type)
             case FeatureVariable::INTEGER_TYPE:
                 return "getFeatureVariableInteger";
             case FeatureVariable::JSON_TYPE:
-                return "getFeatureVariableJson";
+                return "getFeatureVariableJSON";
             case FeatureVariable::STRING_TYPE:
                 return "getFeatureVariableString";
             default:

src/Optimizely/Optimizely.php

@@ -809,7 +809,7 @@ public function getFeatureVariableString($featureFlagKey, $variableKey, $userId,
     *
     * @return array Associative array of json variable including key and value
     */
-    public function getFeatureVariableJson($featureFlagKey, $variableKey, $userId, $attributes = null)
+    public function getFeatureVariableJSON($featureFlagKey, $variableKey, $userId, $attributes = null)
     {
         return $this->getFeatureVariableValueForType(
             $featureFlagKey,

tests/OptimizelyTest.php

@@ -4009,7 +4009,7 @@ public function testGetFeatureVariableString()
         );
     }
 
-    public function testGetFeatureVariableJson()
+    public function testGetFeatureVariableJSON()
     {
         $optimizelyMock = $this->getMockBuilder(Optimizely::class)
             ->setConstructorArgs(array($this->datafile, null, $this->loggerMock))
@@ -4023,11 +4023,11 @@ public function testGetFeatureVariableJson()
             ->will($this->returnValueMap($map));
         $this->assertSame(
             json_decode("{\"text\": \"variable value\"}", true),
-            $optimizelyMock->getFeatureVariableJson('json_single_variable_feature', 'json_variable', 'user_id', [])
+            $optimizelyMock->getFeatureVariableJSON('json_single_variable_feature', 'json_variable', 'user_id', [])
         );
     }
 
-    public function testGetFeatureVariableJsonCallsDecisionListenerGivenUserInExperimentAndFeatureFlagIsEnabled()
+    public function testGetFeatureVariableJSONCallsDecisionListenerGivenUserInExperimentAndFeatureFlagIsEnabled()
     {
         // should return specific value
         $decisionServiceMock = $this->getMockBuilder(DecisionService::class)
@@ -4076,7 +4076,7 @@ public function testGetFeatureVariableJsonCallsDecisionListenerGivenUserInExperi
 
         $this->optimizelyObject->notificationCenter = $this->notificationCenterMock;
 
-        $this->optimizelyObject->getFeatureVariableJson('multiple_variables_feature', 'json_variable', 'user_id', []);
+        $this->optimizelyObject->getFeatureVariableJSON('multiple_variables_feature', 'json_variable', 'user_id', []);
     }
 
     public function testGetAllFeatureVariablesReturnsValuesGivenUserInExperimentAndFeatureFlagIsEnabled()