Skip to content

Commit 49ed2dc

Browse files
chore: remove unused import statement
- Remove import statement for 'log_level' that is no longer used - Update import paths for 'flutter_logger' and 'optimizely_flutter_sdk' test: update test cases in logger_test.dart - Update test cases to use 'const MethodCall' for creating method calls - Change null and empty arguments to be created and handled correctly - Fix missing level or message argument handling scenarios - Improve handling of invalid level data types in method calls docs: add comments to improve code clarity in logger_test.dart - Add comments explaining the purpose of each test group and case - Include comments for the different scenarios being tested in each case
1 parent 8edc431 commit 49ed2dc

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

lib/src/logger/logger_bridge.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import 'dart:async';
22
import 'package:flutter/services.dart';
3-
import 'package:optimizely_flutter_sdk/src/data_objects/log_level.dart';
43
import 'package:optimizely_flutter_sdk/src/logger/flutter_logger.dart';
54
import 'package:optimizely_flutter_sdk/optimizely_flutter_sdk.dart';
65

test/logger_test.dart

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ void main() {
4343
LoggerBridge.initialize(testLogger);
4444

4545
// Simulate native log call by directly invoking the method handler
46-
final methodCall = MethodCall('log', {
46+
final methodCall = const MethodCall('log', {
4747
'level': 3, // INFO
4848
'message': 'Test log message from native'
4949
});
@@ -85,7 +85,7 @@ void main() {
8585
var testLogger = TestLogger();
8686
LoggerBridge.initialize(testLogger);
8787

88-
final methodCall = MethodCall('log', null);
88+
final methodCall = const MethodCall('log', null);
8989
await LoggerBridge.handleMethodCallForTesting(methodCall);
9090

9191
expect(testLogger.logs.isEmpty, isTrue);
@@ -95,7 +95,7 @@ void main() {
9595
var testLogger = TestLogger();
9696
LoggerBridge.initialize(testLogger);
9797

98-
final methodCall = MethodCall('log', {});
98+
final methodCall = const MethodCall('log', {});
9999
await LoggerBridge.handleMethodCallForTesting(methodCall);
100100

101101
expect(testLogger.logs.isEmpty, isTrue);
@@ -105,7 +105,7 @@ void main() {
105105
var testLogger = TestLogger();
106106
LoggerBridge.initialize(testLogger);
107107

108-
final methodCall = MethodCall('log', {
108+
final methodCall = const MethodCall('log', {
109109
'message': 'Test message without level'
110110
});
111111
await LoggerBridge.handleMethodCallForTesting(methodCall);
@@ -117,7 +117,7 @@ void main() {
117117
var testLogger = TestLogger();
118118
LoggerBridge.initialize(testLogger);
119119

120-
final methodCall = MethodCall('log', {
120+
final methodCall = const MethodCall('log', {
121121
'level': 3
122122
});
123123
await LoggerBridge.handleMethodCallForTesting(methodCall);
@@ -130,7 +130,7 @@ void main() {
130130
LoggerBridge.initialize(testLogger);
131131

132132
// Test with string level
133-
var methodCall = MethodCall('log', {
133+
var methodCall = const MethodCall('log', {
134134
'level': 'invalid',
135135
'message': 'Test message'
136136
});
@@ -139,7 +139,7 @@ void main() {
139139
expect(testLogger.logs.isEmpty, isTrue);
140140

141141
// Test with null level
142-
methodCall = MethodCall('log', {
142+
methodCall = const MethodCall('log', {
143143
'level': null,
144144
'message': 'Test message'
145145
});
@@ -154,7 +154,7 @@ void main() {
154154
var testLogger = TestLogger();
155155
LoggerBridge.initialize(testLogger);
156156

157-
final methodCall = MethodCall('unknownMethod', {
157+
final methodCall = const MethodCall('unknownMethod', {
158158
'level': 3,
159159
'message': 'Test message'
160160
});
@@ -368,14 +368,14 @@ void main() {
368368

369369
// Perform various operations
370370
await LoggerBridge.handleMethodCallForTesting(
371-
MethodCall('log', {'level': 1, 'message': 'First message'})
371+
const MethodCall('log', {'level': 1, 'message': 'First message'})
372372
);
373373

374374
expect(LoggerBridge.hasLogger(), isTrue);
375375
expect(testLogger.logs.length, equals(1));
376376

377377
await LoggerBridge.handleMethodCallForTesting(
378-
MethodCall('log', {'level': 2, 'message': 'Second message'})
378+
const MethodCall('log', {'level': 2, 'message': 'Second message'})
379379
);
380380

381381
expect(LoggerBridge.hasLogger(), isTrue);
@@ -394,7 +394,7 @@ void main() {
394394
// Initialize with first logger
395395
LoggerBridge.initialize(testLogger1);
396396
await LoggerBridge.handleMethodCallForTesting(
397-
MethodCall('log', {'level': 3, 'message': 'Message to logger 1'})
397+
const MethodCall('log', {'level': 3, 'message': 'Message to logger 1'})
398398
);
399399

400400
expect(testLogger1.logs.length, equals(1));
@@ -403,7 +403,7 @@ void main() {
403403
// Replace with second logger
404404
LoggerBridge.initialize(testLogger2);
405405
await LoggerBridge.handleMethodCallForTesting(
406-
MethodCall('log', {'level': 3, 'message': 'Message to logger 2'})
406+
const MethodCall('log', {'level': 3, 'message': 'Message to logger 2'})
407407
);
408408

409409
expect(testLogger1.logs.length, equals(1)); // Unchanged
@@ -418,7 +418,7 @@ void main() {
418418
LoggerBridge.initialize(testLogger);
419419

420420
await LoggerBridge.handleMethodCallForTesting(
421-
MethodCall('log', {
421+
const MethodCall('log', {
422422
'level': 3,
423423
'message': ''
424424
})
@@ -452,7 +452,7 @@ void main() {
452452

453453
// Test with double level - should fail gracefully
454454
await LoggerBridge.handleMethodCallForTesting(
455-
MethodCall('log', {
455+
const MethodCall('log', {
456456
'level': 3.0, // Double instead of int
457457
'message': 'Message with double level'
458458
})

0 commit comments

Comments
 (0)