(fix):remove warnings from build (#370)

* remove warnings from build

* bump up the os from 9.2 to 9.4 for travis

* looking at failure on travis of universal

* upgrading to xcode 10

Author: thomaszurkan-optimizely

.travis.yml

@@ -1,5 +1,5 @@
 language: objective-c
-osx_image: xcode9.4
+osx_image: xcode10
 branches:
   only:
     - master
@@ -8,7 +8,7 @@ env:
     - SCHEME=OptimizelySDKiOS TEST_SDK=iphonesimulator PLATFORM='iOS Simulator' OS=9.1 NAME='iPad Air'
     - SCHEME=OptimizelySDKiOS TEST_SDK=iphonesimulator PLATFORM='iOS Simulator' OS=10.1 NAME='iPhone 7 Plus'
     - SCHEME=OptimizelySDKiOS TEST_SDK=iphonesimulator PLATFORM='iOS Simulator' OS=10.3.1 NAME='iPhone 7'
-    - SCHEME=OptimizelySDKiOS-Universal TEST_SDK=iphonesimulator PLATFORM='iOS Simulator' OS=9.3 NAME='iPhone 6s'
+    - SCHEME=OptimizelySDKiOS-Universal TEST_SDK=iphonesimulator PLATFORM='iOS Simulator' OS=11.1 NAME='iPhone 6s'
     - SCHEME=OptimizelySDKTVOS TEST_SDK=appletvsimulator PLATFORM='tvOS Simulator' OS=10.2 NAME='Apple TV 1080p'
     - SCHEME=OptimizelySDKTVOS-Universal TEST_SDK=appletvsimulator PLATFORM='tvOS Simulator' OS=9.2 NAME='Apple TV 1080p'
 before_install: 

OptimizelySDKCore/OptimizelySDKCore/OPTLYEventTagUtil.m

@@ -106,7 +106,6 @@ + (NSNumber *)getNumericValue:(NSDictionary *)eventTags logger:(id<OPTLYLogger>)
     // if the object is an NSNumber, then char, floats, and boolean values will be cast to a double int
     if ([value isKindOfClass:[NSNumber class]]) {
         answer = (NSNumber*)value;
-        const char *objCType = [answer objCType];
 
         if ([self isNSNumberBoolean:answer]) {
             answer = nil;

OptimizelySDKShared/OptimizelySDKShared/OPTLYManagerBase.m

@@ -86,7 +86,9 @@ - (void)cleanUserProfileService:(NSArray<OPTLYExperiment *><OPTLYExperiment> *)e
 //#pragma clang diagnostic push
 //#pragma clang diagnostic ignored "-Warc-performSelector-leaks"
                 @try {
-                    [(NSObject *)self.userProfileService performSelector:selector withObject:ids];
+                    IMP imp = [self.userProfileService.class instanceMethodForSelector:selector];
+                    void (*func)(id, SEL, NSArray *) = (void *)imp;
+                    func(self.userProfileService, selector, ids);
                 }
                 @catch(NSException *e) {
                     [self.logger logMessage:@"Error cleaning up user profile service" withLevel:OptimizelyLogLevelError];

OptimizelySDKUserProfileService/OptimizelySDKUserProfileServiceTests/OptimizelySDKUserProfileServiceTests.m

@@ -316,9 +316,14 @@ - (void)testWhitelistingOverridesUserProfileAndStoresNothing {
 - (void)testRemoveInvalidExperiments
 {
     if (self.userProfileService ) {
-        [self.userProfileService performSelector:@selector(removeInvalidExperimentsForAllUsers:) withObject:@[]];
-        [self.userProfileService performSelector:@selector(removeInvalidExperimentsForAllUsers:) withObject:nil];
-        [self.userProfileService performSelector:@selector(removeInvalidExperimentsForAllUsers:) withObject:@[kExperimentId3a]];
+        SEL selector = NSSelectorFromString(@"removeInvalidExperimentsForAllUsers:");
+        
+        IMP imp = [self.userProfileService.class instanceMethodForSelector:selector];
+        void (*func)(id, SEL, NSArray *) = (void *)imp;
+
+        func(self.userProfileService, selector, @[]);
+        func(self.userProfileService, selector, nil);
+        func(self.userProfileService, selector, @[kExperimentId3a]);
     }
     NSDictionary *userProfile1 = [self.userProfileService lookup:kUserId1];
     XCTAssertNil(userProfile1[kExperimentId3a], @"User profile experiment entry should be removed");