Add tests for reactor options

Author: jordangarcia

src/reactor.js

@@ -23,9 +23,10 @@ import {
  */
 class Reactor {
   constructor(config = {}) {
-    const baseOptions = config.debug ? DEBUG_OPTIONS : PROD_OPTIONS
+    const debug = !!config.debug
+    const baseOptions = debug ? DEBUG_OPTIONS : PROD_OPTIONS
     const initialReactorState = new ReactorState({
-      debug: config.debug,
+      debug: debug,
       // merge config options with the defaults
       options: baseOptions.merge(config.options || {}),
     })

src/reactor/fns.js

@@ -192,7 +192,11 @@ export function addObserver(observerState, getter, handler) {
  * @return {Boolean}
  */
 export function getOption(reactorState, option) {
-  return reactorState.getIn(['options', option], false)
+  const value = reactorState.getIn(['options', option])
+  if (value === undefined) {
+    throw new Error('Invalid option: ' + option)
+  }
+  return value
 }
 
 /**

src/reactor/records.js

@@ -1,5 +1,20 @@
 import { Map, Set, Record } from 'immutable'
 
+export const PROD_OPTIONS = Map({
+  // logs information for each dispatch
+  logDispatches: false,
+  // log the entire app state after each dispatch
+  logAppState: false,
+  // logs what stores changed after a dispatch
+  logDirtyStores: false,
+  // if false, throw an error if a store returns undefined
+  allowUndefinedDispatch: true,
+  // if false, throw an error if a store returns undefined
+  allowNonImmutableStores: true,
+  // if false throw when dispatching in dispatch
+  allowDispatchInDispatch: true,
+})
+
 export const ReactorState = Record({
   dispatchId: 0,
   state: Map(),
@@ -10,7 +25,7 @@ export const ReactorState = Record({
   dirtyStores: Set(),
   debug: false,
   // production defaults
-  options: Map({}),
+  options: PROD_OPTIONS,
 })
 
 export const ObserverState = Record({
@@ -39,17 +54,3 @@ export const DEBUG_OPTIONS = Map({
   allowDispatchInDispatch: false,
 })
 
-export const PROD_OPTIONS = Map({
-  // logs information for each dispatch
-  logDispatches: false,
-  // log the entire app state after each dispatch
-  logAppState: false,
-  // logs what stores changed after a dispatch
-  logDirtyStores: false,
-  // if false, throw an error if a store returns undefined
-  allowUndefinedDispatch: true,
-  // if false, throw an error if a store returns undefined
-  allowNonImmutableStores: true,
-  // if false throw when dispatching in dispatch
-  allowDispatchInDispatch: true,
-})

tests/reactor-fns-tests.js

@@ -2,7 +2,7 @@
 import { Map, Set, is } from 'immutable'
 import { Store } from '../src/main'
 import * as fns from '../src/reactor/fns'
-import { ReactorState, ObserverState } from '../src/reactor/records'
+import { ReactorState, ObserverState, DEBUG_OPTIONS } from '../src/reactor/records'
 import { toImmutable } from '../src/immutable-helpers'
 
 describe('reactor fns', () => {
@@ -501,5 +501,29 @@ describe('reactor fns', () => {
       })
     })
   })
+  describe('#getDebugOption', () => {
+    it('should parse the option value in a reactorState', () => {
+      const reactorState = new ReactorState({
+        options: Map({
+          allowUndefinedDispatch: true,
+        }),
+      })
+
+      const result = fns.getOption(reactorState, 'allowUndefinedDispatch')
+      expect(result).toBe(true)
+    })
+
+    it('should throw an error if the option doesn\'t', () => {
+      const reactorState = new ReactorState({
+        options: Map({
+          allowUndefinedDispatch: true,
+        }),
+      })
+
+      expect(function() {
+        const result = fns.getOption(reactorState, 'unknownOption')
+      }).toThrow()
+    })
+  })
 })
 /*eslint-enable one-var, comma-dangle*/

tests/reactor-tests.js

@@ -1,6 +1,8 @@
 import Immutable, { Map, List, is } from 'immutable'
 import { Reactor, Store } from '../src/main'
+import { getOption } from '../src/reactor/fns'
 import { toImmutable } from '../src/immutable-helpers'
+import { PROD_OPTIONS, DEBUG_OPTIONS } from '../src/reactor/records'
 import logging from '../src/logging'
 
 describe('Reactor', () => {
@@ -9,6 +11,49 @@ describe('Reactor', () => {
     expect(reactor instanceof Reactor).toBe(true)
   })
 
+  describe('debug and options flags', () => {
+    it('should create a reactor with PROD_OPTIONS', () => {
+      var reactor = new Reactor()
+      expect(reactor.reactorState.get('debug')).toBe(false)
+      expect(is(reactor.reactorState.get('options'), PROD_OPTIONS)).toBe(true)
+    })
+    it('should create a reactor with DEBUG_OPTIONS', () => {
+      var reactor = new Reactor({
+        debug: true,
+      })
+      expect(reactor.reactorState.get('debug')).toBe(true)
+      expect(is(reactor.reactorState.get('options'), DEBUG_OPTIONS)).toBe(true)
+    })
+    it('should override PROD options', () => {
+      var reactor = new Reactor({
+        options: {
+          logDispatches: true,
+        }
+      })
+      expect(getOption(reactor.reactorState, 'logDispatches')).toBe(true)
+      expect(getOption(reactor.reactorState, 'logAppState')).toBe(false)
+      expect(getOption(reactor.reactorState, 'logDirtyStores')).toBe(false)
+      expect(getOption(reactor.reactorState, 'allowUndefinedDispatch')).toBe(true)
+      expect(getOption(reactor.reactorState, 'allowNonImmutableStores')).toBe(true)
+      expect(getOption(reactor.reactorState, 'allowDispatchInDispatch')).toBe(true)
+    })
+    it('should override DEBUG options', () => {
+      var reactor = new Reactor({
+        debug: true,
+        options: {
+          logDispatches: false,
+          allowDispatchInDispatch: true,
+        }
+      })
+      expect(getOption(reactor.reactorState, 'logDispatches')).toBe(false)
+      expect(getOption(reactor.reactorState, 'logAppState')).toBe(true)
+      expect(getOption(reactor.reactorState, 'logDirtyStores')).toBe(true)
+      expect(getOption(reactor.reactorState, 'allowUndefinedDispatch')).toBe(false)
+      expect(getOption(reactor.reactorState, 'allowNonImmutableStores')).toBe(false)
+      expect(getOption(reactor.reactorState, 'allowDispatchInDispatch')).toBe(true)
+    })
+  })
+
   describe('Reactor with no initial state', () => {
     var checkoutActions
     var reactor