Fix logLevel configuration (#34)

* Pass through logLevel in createInstance

* Support NOT_SET (0) logLevel

* Add tests

* Fix defaultLogger

Author: delikat

index.js

@@ -26,8 +26,8 @@ module.exports = {
    * @throws If any of the config options that were passed in are invalid
    */
   createInstance: function(config) {
-    var logLevel = config.logLevel || enums.LOG_LEVEL.INFO;
-    var defaultLogger = logger.createLogger({ logLevel: logLevel });
+    var logLevel = 'logLevel' in config ? config.logLevel : enums.LOG_LEVEL.INFO;
+    var defaultLogger = logger.createLogger({ logLevel: enums.LOG_LEVEL.INFO });
     if (config) {
       try {
         configValidator.validate(config);
@@ -48,7 +48,7 @@ module.exports = {
       clientVersion: JAVASCRIPT_CLIENT_VERSION,
       errorHandler: defaultErrorHandler,
       eventDispatcher: defaultEventDispatcher,
-      logger: logger.createLogger({ logLevel: enums.LOG_LEVEL.INFO }),
+      logger: logger.createLogger({ logLevel: logLevel }),
     }, config);
 
     return new Optimizely(config);

tests.js

@@ -1,4 +1,5 @@
 var configValidator = require('optimizely-server-sdk/lib/utils/config_validator');
+var enums = require('optimizely-server-sdk/lib/utils/enums');
 var Optimizely = require('optimizely-server-sdk/lib/optimizely');
 var optimizelyFactory = require('./');
 var packageJSON = require('./package.json');
@@ -44,7 +45,7 @@ describe('javascript-sdk', function() {
         assert.instanceOf(optlyInstance, Optimizely);
       });
 
-      it('should set the Javascript client engine and version', function() {
+      it('should set the JavaScript client engine and version', function() {
         var optlyInstance = optimizelyFactory.createInstance({
           datafile: {},
           errorHandler: fakeErrorHandler,
@@ -55,6 +56,23 @@ describe('javascript-sdk', function() {
         assert.equal('javascript-sdk', optlyInstance.clientEngine);
         assert.equal(packageJSON.version, optlyInstance.clientVersion);
       });
+
+      it('should instantiate the logger with a custom logLevel when provided', function() {
+        var optlyInstance = optimizelyFactory.createInstance({
+          datafile: {},
+          logLevel: enums.LOG_LEVEL.ERROR,
+        });
+
+        assert.equal(optlyInstance.logger.logLevel, enums.LOG_LEVEL.ERROR);
+      });
+
+      it('should default to INFO when no logLevel is provided', function() {
+        var optlyInstance = optimizelyFactory.createInstance({
+          datafile: {},
+        });
+
+        assert.equal(optlyInstance.logger.logLevel, enums.LOG_LEVEL.INFO);
+      });
     });
   });
 });