feat: Convert event dispatcher node plugin to TS (#677)

* WIP

* Finish conversion

* Specify baseUrl and paths instead of types for custom type definitions

* NIT

Author: yavorona

packages/optimizely-sdk/lib/plugins/event_dispatcher/index.node.js renamed to packages/optimizely-sdk/lib/plugins/event_dispatcher/index.node.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright 2016-2018, 2020, Optimizely
+ * Copyright 2016-2018, 2020-2021, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,26 +17,31 @@ import http from 'http';
 import https from 'https';
 import url from 'url';
 
+import { Event } from '../../shared_types';
+
 /**
  * Dispatch an HTTP request to the given url and the specified options
- * @param {Object}  eventObj          Event object containing
- * @param {string}  eventObj.url      the url to make the request to
- * @param {Object}  eventObj.params   parameters to pass to the request (i.e. in the POST body)
- * @param {string}  eventObj.httpVerb the HTTP request method type. only POST is supported.
- * @param {function} callback         callback to execute
- * @return {ClientRequest|undefined}          ClientRequest object which made the request, or undefined if no request was made (error)
+ * @param  {Event}    eventObj           Event object containing
+ * @param  {string}   eventObj.url       the url to make the request to
+ * @param  {Object}   eventObj.params    parameters to pass to the request (i.e. in the POST body)
+ * @param  {string}   eventObj.httpVerb  the HTTP request method type. only POST is supported.
+ * @param  {function} callback           callback to execute
+ * @return {ClientRequest|undefined}     ClientRequest object which made the request, or undefined if no request was made (error)
  */
-export var dispatchEvent = function(eventObj, callback) {
+export const dispatchEvent = function(
+  eventObj: Event,
+  callback: (response: { statusCode: number }) => void
+): http.ClientRequest | void {
   // Non-POST requests not supported
   if (eventObj.httpVerb !== 'POST') {
     return;
   }
 
-  var parsedUrl = url.parse(eventObj.url);
+  const parsedUrl = url.parse(eventObj.url);
 
-  var dataString = JSON.stringify(eventObj.params);
+  const dataString = JSON.stringify(eventObj.params);
 
-  var requestOptions = {
+  const requestOptions = {
     host: parsedUrl.host,
     path: parsedUrl.path,
     method: 'POST',
@@ -46,13 +51,14 @@ export var dispatchEvent = function(eventObj, callback) {
     },
   };
 
-  var requestCallback = function(response) {
+  const requestCallback = function(response?: { statusCode: number }): void {
     if (response && response.statusCode && response.statusCode >= 200 && response.statusCode < 400) {
       callback(response);
     }
   };
 
-  var req = (parsedUrl.protocol === 'http:' ? http : https).request(requestOptions, requestCallback);
+  const req = (parsedUrl.protocol === 'http:' ? http : https)
+    .request(requestOptions, requestCallback as (res: http.IncomingMessage) => void);
   // Add no-op error listener to prevent this from throwing
   req.on('error', function() {});
   req.write(dataString);

packages/optimizely-sdk/tsconfig.json

@@ -1,7 +1,10 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "types": ["./typings"],
+    "baseUrl": "./",
+    "paths": {
+      "*" : ["*", "./typings/*"]
+    },
     "allowJs": true,
     "declaration": false,
     "module": "esnext",