feat(api): Decision Notification Listener for isFeatureEnabled and getEnabledFeatures APIs. (#245)

Author: mfahadahmed

packages/optimizely-sdk/lib/core/decision_service/index.js

@@ -303,12 +303,7 @@ DecisionService.prototype.getVariationForFeature = function(feature, userId, att
   }
 
   this.logger.log(LOG_LEVEL.DEBUG, sprintf(LOG_MESSAGES.USER_NOT_IN_ROLLOUT, MODULE_NAME, userId, feature.key));
-
-  return {
-    experiment: null,
-    variation: null,
-    decisionSource: null,
-  };
+  return rolloutDecision;
 };
 
 DecisionService.prototype._getVariationForFeatureExperiment = function(feature, userId, attributes) {

packages/optimizely-sdk/lib/core/decision_service/index.tests.js

@@ -843,12 +843,12 @@ describe('lib/core/decision_service', function() {
             getVariationStub.returns(null);
           });
 
-          it('returns a decision with no variation', function() {
+          it('returns a decision with no variation and source rollout', function() {
             var decision = decisionServiceInstance.getVariationForFeature(feature, 'user1');
             var expectedDecision = {
               experiment: null,
               variation: null,
-              decisionSource: null,
+              decisionSource: DECISION_SOURCES.ROLLOUT,
             };
             assert.deepEqual(decision, expectedDecision);
             sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: User user1 is not in any experiment on the feature test_feature_for_experiment.');
@@ -915,12 +915,12 @@ describe('lib/core/decision_service', function() {
             getVariationStub.returns(null);
           });
 
-          it('returns a decision with no experiment and no variation', function() {
+          it('returns a decision with no experiment, no variation and source rollout', function() {
             var decision = decisionServiceInstance.getVariationForFeature(feature, 'user1');
             var expectedDecision = {
               experiment: null,
               variation: null,
-              decisionSource: null,
+              decisionSource: DECISION_SOURCES.ROLLOUT,
             };
             assert.deepEqual(decision, expectedDecision);
             sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: User user1 is not in any experiment on the feature feature_with_group.');
@@ -932,7 +932,7 @@ describe('lib/core/decision_service', function() {
             var expectedDecision = {
               experiment: null,
               variation: null,
-              decisionSource: null,
+              decisionSource: DECISION_SOURCES.ROLLOUT,
             };
             assert.deepEqual(decision, expectedDecision);
             sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: User user1 is not in any experiment on the feature feature_exp_no_traffic.');
@@ -946,12 +946,12 @@ describe('lib/core/decision_service', function() {
             bucketUserIntoExperimentStub.returns(null);
           });
 
-          it('returns a decision with no experiment and no variation', function() {
+          it('returns a decision with no experiment, no variation and source rollout', function() {
             var decision = decisionServiceInstance.getVariationForFeature(feature, 'user1');
             var expectedDecision = {
               experiment: null,
               variation: null,
-              decisionSource: null,
+              decisionSource: DECISION_SOURCES.ROLLOUT,
             };
             assert.deepEqual(decision, expectedDecision);
             sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: User user1 is not in any experiment on the feature feature_with_group.');
@@ -1168,12 +1168,12 @@ describe('lib/core/decision_service', function() {
             bucketStub.returns(null);
           });
 
-          it('returns a decision with no variation and no experiment', function() {
+          it('returns a decision with no variation, no experiment and source rollout', function() {
             var decision = decisionServiceInstance.getVariationForFeature(feature, 'user1');
             var expectedDecision = {
               experiment: null,
               variation: null,
-              decisionSource: null,
+              decisionSource: DECISION_SOURCES.ROLLOUT,
             };
             assert.deepEqual(decision, expectedDecision);
             sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: User user1 does not meet conditions for targeting rule 1.');
@@ -1378,12 +1378,12 @@ describe('lib/core/decision_service', function() {
           feature = configObj.featureKeyMap.unused_flag;
         });
 
-        it('returns a decision with no variation and no experiment', function() {
+        it('returns a decision with no variation, no experiment and source rollout', function() {
           var decision = decisionServiceInstance.getVariationForFeature(feature, 'user1');
           var expectedDecision = {
             experiment: null,
             variation: null,
-            decisionSource: null,
+            decisionSource: DECISION_SOURCES.ROLLOUT,
           };
           var expectedDecision = assert.deepEqual(decision, expectedDecision);
           sinon.assert.calledWithExactly(mockLogger.log, LOG_LEVEL.DEBUG, 'DECISION_SERVICE: Feature unused_flag is not attached to any experiments.');

packages/optimizely-sdk/lib/optimizely/index.js

@@ -502,26 +502,46 @@ Optimizely.prototype.isFeatureEnabled = function(featureKey, userId, attributes)
       return false;
     }
 
+    var featureEnabled = false;
+    var experimentKey = null;
+    var variationKey = null;
     var decision = this.decisionService.getVariationForFeature(feature, userId, attributes);
     var variation = decision.variation;
+    
     if (!!variation) {
+      featureEnabled = variation.featureEnabled;
       if (decision.decisionSource === DECISION_SOURCES.EXPERIMENT) {
+        experimentKey = decision.experiment.key;
+        variationKey = decision.variation.key;
         // got a variation from the exp, so we track the impression
         this._sendImpressionEvent(decision.experiment.key, decision.variation.key, userId, attributes);
       }
-      if (variation.featureEnabled === true) {
-        this.logger.log(
-          LOG_LEVEL.INFO,
-          sprintf(LOG_MESSAGES.FEATURE_ENABLED_FOR_USER, MODULE_NAME, featureKey, userId)
-        );
-        return true;
-      }
     }
-    this.logger.log(
-      LOG_LEVEL.INFO,
-      sprintf(LOG_MESSAGES.FEATURE_NOT_ENABLED_FOR_USER, MODULE_NAME, featureKey, userId)
+    
+    if (featureEnabled === true) {
+      this.logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FEATURE_ENABLED_FOR_USER, MODULE_NAME, featureKey, userId));
+    } else {
+      this.logger.log(LOG_LEVEL.INFO, sprintf(LOG_MESSAGES.FEATURE_NOT_ENABLED_FOR_USER, MODULE_NAME, featureKey, userId));
+      featureEnabled = false;
+    }
+
+    this.notificationCenter.sendNotifications(
+      enums.NOTIFICATION_TYPES.DECISION,
+      {
+        type: DECISION_INFO_TYPES.FEATURE,
+        userId: userId,
+        attributes: attributes || {},
+        decisionInfo: {
+          featureKey: featureKey,
+          featureEnabled: featureEnabled,
+          source: decision.decisionSource,
+          sourceExperimentKey: experimentKey,
+          sourceVariationKey: variationKey,
+        }
+      }
     );
-    return false;
+
+    return featureEnabled;
   } catch (e) {
     this.logger.log(LOG_LEVEL.ERROR, e.message);
     this.errorHandler.handleError(e);