Removed sorting and its unit test (#177)

Author: mnoman09

core-api/src/main/java/com/optimizely/ab/Optimizely.java

@@ -38,9 +38,7 @@
 import com.optimizely.ab.event.internal.BuildVersionInfo;
 import com.optimizely.ab.event.internal.EventBuilder;
 import com.optimizely.ab.event.internal.payload.EventBatch.ClientEngine;
-import com.optimizely.ab.internal.EventTagUtils;
 import com.optimizely.ab.notification.NotificationCenter;
-import com.optimizely.ab.notification.NotificationListener;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -600,7 +598,7 @@ public List<String> getEnabledFeatures(@Nonnull String userId,@Nonnull Map<Strin
             if(isFeatureEnabled(featureKey, userId, attributes))
                 enabledFeaturesList.add(featureKey);
         }
-        Collections.sort(enabledFeaturesList);
+
         return enabledFeaturesList;
     }
 

core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java

@@ -17,7 +17,6 @@
 
 import ch.qos.logback.classic.Level;
 import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.Ordering;
 import com.optimizely.ab.bucketing.Bucketer;
 import com.optimizely.ab.bucketing.DecisionService;
 import com.optimizely.ab.bucketing.FeatureDecision;
@@ -3393,37 +3392,6 @@ public void getEnabledFeatureWithValidUserId() throws ConfigParseException{
 
     }
 
-    /**
-     * Verify {@link Optimizely#getEnabledFeatures(String, Map)} calls into
-     * {@link Optimizely#isFeatureEnabled(String, String, Map)} for each featureFlag
-     * return sorted List of FeatureFlags
-     * Also checks that the orignal list directly from projectConfig is unsorted
-     */
-    @Test
-    public void getEnabledFeatureCheckingListIsSorted() throws ConfigParseException{
-        assumeTrue(datafileVersion >= Integer.parseInt(ProjectConfig.Version.V4.toString()));
-
-        Optimizely spyOptimizely = spy(Optimizely.builder(validDatafile, mockEventHandler)
-                .withConfig(validProjectConfig)
-                .build());
-        ArrayList<String> featureFlagsSortedList = (ArrayList<String>) spyOptimizely.getEnabledFeatures(genericUserId,
-                new HashMap<String, String>());
-        assertFalse(featureFlagsSortedList.isEmpty());
-
-        //To get Unsorted list directly from project config
-        List<String> unSortedFeaturesListFromProjectConfig = new ArrayList<String>();
-        for (FeatureFlag featureFlag : spyOptimizely.projectConfig.getFeatureFlags()){
-            String featureKey = featureFlag.getKey();
-            unSortedFeaturesListFromProjectConfig.add(featureKey);
-        }
-
-        //unSortedFeaturesListFromProjectConfig will retain only the elements which are also contained in featureFlagsSortedList.
-        unSortedFeaturesListFromProjectConfig.retainAll(featureFlagsSortedList);
-        assertFalse(Ordering.natural().isOrdered(unSortedFeaturesListFromProjectConfig));
-
-        assertTrue(Ordering.natural().isOrdered(featureFlagsSortedList));
-    }
-
     /**
      * Verify {@link Optimizely#getEnabledFeatures(String, Map)} calls into
      * {@link Optimizely#isFeatureEnabled(String, String, Map)} for each featureFlag sending