fix: correct visibility and initialization of constants in ValidProjectConfigV4

- Change visibility of FEATURE_FLAG_BOOLEAN_FEATURE to public
- Change visibility of Variation VARIATION_HOLDOUT_VARIATION_OFF to public
- Update entityIds in HOLDOUT_BASIC_HOLDOUT and holdouts-project-config.json to use "$opt_dummy_variation_id" instead of hardcoded values

Author: muzahidul-opti

core-api/src/test/java/com/optimizely/ab/bucketing/DecisionServiceTest.java

@@ -1228,4 +1228,29 @@ public void setForcedVariationMultipleUsers() {
         assertNull(decisionService.getForcedVariation(experiment2, "testUser2").getResult());
     }
 
+    @Test
+    public void getVariationForFeatureReturnHoldoutDecisionForGlobalHoldout() {
+        ProjectConfig holdoutProjectConfig = generateValidProjectConfigV4_holdout();
+        
+        Bucketer mockBucketer = new Bucketer();
+        
+        DecisionService decisionService = new DecisionService(mockBucketer, mockErrorHandler, null);
+        
+        Map<String, Object> attributes = new HashMap<>();
+        attributes.put("$opt_bucketing_id", "ppid160000");
+        FeatureDecision featureDecision = decisionService.getVariationForFeature(
+            FEATURE_FLAG_BOOLEAN_FEATURE,
+            optimizely.createUserContext("user123", attributes),
+            holdoutProjectConfig
+        ).getResult();
+        
+        assertEquals(VARIATION_HOLDOUT_VARIATION_OFF, featureDecision.variation);
+        assertEquals(FeatureDecision.DecisionSource.HOLDOUT, featureDecision.decisionSource);
+        
+        logbackVerifier.expectMessage(Level.INFO, "User (user123) is in variation (ho_off_key) of holdout (basic_holdout).");
+    }
+    
+
+
+
 }

core-api/src/test/java/com/optimizely/ab/config/ValidProjectConfigV4.java

@@ -235,7 +235,7 @@ public class ValidProjectConfigV4 {
     // features
     private static final String FEATURE_BOOLEAN_FEATURE_ID = "4195505407";
     private static final String FEATURE_BOOLEAN_FEATURE_KEY = "boolean_feature";
-    private static final FeatureFlag FEATURE_FLAG_BOOLEAN_FEATURE = new FeatureFlag(
+    public static final FeatureFlag FEATURE_FLAG_BOOLEAN_FEATURE = new FeatureFlag(
         FEATURE_BOOLEAN_FEATURE_ID,
         FEATURE_BOOLEAN_FEATURE_KEY,
         "",
@@ -490,7 +490,7 @@ public class ValidProjectConfigV4 {
         VARIATION_BASIC_EXPERIMENT_VARIATION_A_KEY,
         Collections.<FeatureVariableUsageInstance>emptyList()
     );
-    private static final Variation VARIATION_HOLDOUT_VARIATION_OFF = new Variation(
+    public static final Variation VARIATION_HOLDOUT_VARIATION_OFF = new Variation(
         "$opt_dummy_variation_id",
         "ho_off_key",
         false
@@ -536,7 +536,7 @@ public class ValidProjectConfigV4 {
             )
         )
     );
-    private static final Holdout HOLDOUT_BASIC_HOLDOUT = new Holdout(
+    public static final Holdout HOLDOUT_BASIC_HOLDOUT = new Holdout(
         "10075323428",
         "basic_holdout",
         Holdout.HoldoutStatus.RUNNING.toString(),
@@ -547,7 +547,7 @@ public class ValidProjectConfigV4 {
         ),
         DatafileProjectConfigTestUtils.createListOfObjects(
             new TrafficAllocation(
-                "327323",
+                "$opt_dummy_variation_id",
                 500
             )
         ),
@@ -566,7 +566,7 @@ public class ValidProjectConfigV4 {
             ),
             DatafileProjectConfigTestUtils.createListOfObjects(
                 new TrafficAllocation(
-                        "327323",
+                        "$opt_dummy_variation_id",
                         0
                 )
             ),
@@ -585,7 +585,7 @@ public class ValidProjectConfigV4 {
             ),
             DatafileProjectConfigTestUtils.createListOfObjects(
                 new TrafficAllocation(
-                        "327323",
+                        "$opt_dummy_variation_id",
                         2000
                 )
             ),
@@ -608,7 +608,7 @@ public class ValidProjectConfigV4 {
             ),
             DatafileProjectConfigTestUtils.createListOfObjects(
                 new TrafficAllocation(
-                        "327323",
+                        "$opt_dummy_variation_id",
                         1500
                 )
             ),
@@ -636,7 +636,7 @@ public class ValidProjectConfigV4 {
             ),
             DatafileProjectConfigTestUtils.createListOfObjects(
                 new TrafficAllocation(
-                    "327323",
+                    "$opt_dummy_variation_id",
                     1000
                 )
             ),

core-api/src/test/resources/config/holdouts-project-config.json

@@ -483,7 +483,7 @@
       "trafficAllocation": [
         {
           "endOfRange": 0,
-          "entityId": "327323"
+          "entityId": "$opt_dummy_variation_id"
         }
       ],
       "variations": [
@@ -502,7 +502,7 @@
       "trafficAllocation": [
         {
           "endOfRange": 2000,
-          "entityId": "327323"
+          "entityId": "$opt_dummy_variation_id"
         }
       ],
       "variations": [
@@ -526,7 +526,7 @@
       "trafficAllocation": [
         {
           "endOfRange": 500,
-          "entityId": "327323"
+          "entityId": "$opt_dummy_variation_id"
         }
       ],
       "variations": [
@@ -544,7 +544,7 @@
       "trafficAllocation": [
         {
           "endOfRange": 1000,
-          "entityId": "327323"
+          "entityId": "$opt_dummy_variation_id"
         }
       ],
       "variations": [
@@ -565,7 +565,7 @@
       "trafficAllocation": [
         {
           "endOfRange": 1500,
-          "entityId": "327323"
+          "entityId": "$opt_dummy_variation_id"
         }
       ],
       "variations": [