Fix: Filter Empty key attributes from payload (#222)

Author: mnoman09

core-api/src/main/java/com/optimizely/ab/event/internal/EventFactory.java

@@ -168,6 +168,12 @@ private List<Attribute> buildAttributeList(ProjectConfig projectConfig, Map<Stri
         List<Attribute> attributesList = new ArrayList<Attribute>();
 
         for (Map.Entry<String, ?> entry : attributes.entrySet()) {
+
+            //Ignore attributes with empty key
+            if (entry.getKey().isEmpty()) {
+                continue;
+            }
+
             // Filter down to the types of values we're allowed to track.
             // Don't allow Longs, BigIntegers, or BigDecimals - they /can/ theoretically be serialized as JSON numbers
             // but may take on values that can't be faithfully parsed by the backend.

core-api/src/test/java/com/optimizely/ab/config/ValidProjectConfigV4.java

@@ -61,6 +61,10 @@ public class ValidProjectConfigV4 {
     public  static final String     ATTRIBUTE_DOUBLE_KEY = "doubleKey";
     private static final Attribute  ATTRIBUTE_DOUBLE = new Attribute(ATTRIBUTE_DOUBLE_ID, ATTRIBUTE_DOUBLE_KEY);
 
+    private static final String     ATTRIBUTE_EMPTY_KEY_ID = "808797686";
+    public  static final String     ATTRIBUTE_EMPTY_KEY = "";
+    private static final Attribute  ATTRIBUTE_EMPTY = new Attribute(ATTRIBUTE_EMPTY_KEY_ID, ATTRIBUTE_EMPTY_KEY);
+
     // audiences
     private static final String     CUSTOM_ATTRIBUTE_TYPE = "custom_attribute";
     private static final String     AUDIENCE_BOOL_ID = "3468206643";
@@ -1158,6 +1162,7 @@ public static ProjectConfig generateValidProjectConfigV4() {
         attributes.add(ATTRIBUTE_BOOLEAN);
         attributes.add(ATTRIBUTE_INTEGER);
         attributes.add(ATTRIBUTE_DOUBLE);
+        attributes.add(ATTRIBUTE_EMPTY);
 
         // list audiences
         List<Audience> audiences = new ArrayList<Audience>();

core-api/src/test/java/com/optimizely/ab/event/internal/EventFactoryTest.java

@@ -271,6 +271,7 @@ public void createConversionEventIgnoresInvalidAndAcceptsValidAttributes() {
         Attribute doubleAttribute = validProjectConfig.getAttributes().get(5);
         Attribute integerAttribute = validProjectConfig.getAttributes().get(4);
         Attribute boolAttribute = validProjectConfig.getAttributes().get(3);
+        Attribute emptyAttribute = validProjectConfig.getAttributes().get(6);
 
         BigInteger bigInteger = new BigInteger("12323");
         BigDecimal bigDecimal = new BigDecimal("123");
@@ -288,6 +289,7 @@ public void createConversionEventIgnoresInvalidAndAcceptsValidAttributes() {
         attributes.put(doubleAttribute.getKey(), validDoubleAttribute);
         attributes.put(integerAttribute.getKey(), validIntegerAttribute);
         attributes.put(boolAttribute.getKey(), validBoolAttribute);
+        attributes.put(emptyAttribute.getKey(), validBoolAttribute);
 
         DecisionService decisionService = new DecisionService(
                 mockBucketAlgorithm,
@@ -328,6 +330,8 @@ public void createConversionEventIgnoresInvalidAndAcceptsValidAttributes() {
             assertNotSame(feature.getValue(), bigInteger);
             assertNotSame(feature.getKey(), attribute2.getKey());
             assertNotSame(feature.getValue(), bigDecimal);
+            assertNotSame(feature.getKey(), emptyAttribute.getKey());
+            assertNotSame(feature.getValue(), doubleAttribute);
         }
     }
 

core-api/src/test/resources/config/valid-project-config-v4.json

@@ -88,6 +88,10 @@
     {
       "id": "808797686",
       "key": "doubleKey"
+    },
+    {
+      "id": "808797686",
+      "key": ""
     }
   ],
   "events": [