Added semversioning additional invalid unit Tests. (#393)

Co-authored-by: msohailhussain <mirza.sohailhussain@gmail.com>

Author: mnoman09

core-api/src/main/java/com/optimizely/ab/config/audience/match/SemanticVersion.java

@@ -82,8 +82,20 @@ public boolean isBuild() {
         return version.contains(BUILD_SEPERATOR);
     }
 
+    private int dotCount(String prefixVersion) {
+        char[] vCharArray = prefixVersion.toCharArray();
+        int count = 0;
+        for (char c : vCharArray) {
+            if (c == '.') {
+                count++;
+            }
+        }
+        return count;
+    }
+
     public String[] splitSemanticVersion() throws Exception {
         List<String> versionParts = new ArrayList<>();
+        String versionPrefix = "";
         // pre-release or build.
         String versionSuffix = "";
         // for example: beta.2.1
@@ -103,16 +115,19 @@ public String[] splitSemanticVersion() throws Exception {
                 throw new Exception("Invalid Semantic Version.");
             }
             // major.minor.patch
-            String versionPrefix = partialVersionParts[0];
+            versionPrefix = partialVersionParts[0];
 
             versionSuffix = partialVersionParts[1];
 
-            preVersionParts = versionPrefix.split("\\.");
         } else {
-            preVersionParts = version.split("\\.");
+            versionPrefix = version;
         }
 
-        if (preVersionParts.length > 3) {
+        preVersionParts = versionPrefix.split("\\.");
+
+        if (preVersionParts.length > 3 ||
+            preVersionParts.length == 0 ||
+            dotCount(versionPrefix) >= preVersionParts.length) {
             // Throw error as pre version should only contain major.minor.patch version
             throw new Exception("Invalid Semantic Version.");
         }

core-api/src/test/java/com/optimizely/ab/config/audience/SemanticVersionTest.java

@@ -27,6 +27,84 @@ public class SemanticVersionTest {
     @Rule
     public ExpectedException thrown = ExpectedException.none();
 
+
+    @Test
+    public void semanticVersionInvalidOnlyDash() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion("-");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidOnlyDot() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion(".");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidDoubleDot() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion("..");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidPlus() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion("+");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidPlusTest() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion("+test");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidOnlySpace() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion(" ");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidSpaces() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion("2 .3. 0");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidDotButNoMinorVersion() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion("2.");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidDotButNoMajorVersion() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion(".2.1");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidComma() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion(",");
+        semanticVersion.splitSemanticVersion();
+    }
+
+    @Test
+    public void semanticVersionInvalidMissingMajorMinorPatch() throws Exception {
+        thrown.expect(Exception.class);
+        SemanticVersion semanticVersion = new SemanticVersion("+build-prerelease");
+        semanticVersion.splitSemanticVersion();
+    }
+
     @Test
     public void semanticVersionInvalidMajorShouldBeNumberOnly() throws Exception {
         thrown.expect(Exception.class);