Fix test isolation in OptimizelyTest class. (#273)

Author: Mike Davis

core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java

@@ -91,25 +91,16 @@ public class OptimizelyTest {
     public static Collection<Object[]> data() throws IOException {
         return Arrays.asList(new Object[][]{
             {
-                2,
                 validConfigJsonV2(),
                 noAudienceProjectConfigJsonV2(),
-                validProjectConfigV2(),
-                noAudienceProjectConfigV2()
             },
             {
-                3,
                 validConfigJsonV3(),
-                noAudienceProjectConfigJsonV3(),
-                validProjectConfigV3(),
-                noAudienceProjectConfigV3()
+                noAudienceProjectConfigJsonV3(),  // FIX-ME this is not a valid v3 datafile
             },
             {
-                4,
                 validConfigJsonV4(),
-                validConfigJsonV4(),
-                validProjectConfigV4(),
-                validProjectConfigV4()
+                validConfigJsonV4()
             }
         });
     }
@@ -146,16 +137,17 @@ public static Collection<Object[]> data() throws IOException {
     private ProjectConfig validProjectConfig;
     private ProjectConfig noAudienceProjectConfig;
 
-    public OptimizelyTest(int datafileVersion,
-                          String validDatafile,
-                          String noAudienceDatafile,
-                          ProjectConfig validProjectConfig,
-                          ProjectConfig noAudienceProjectConfig) {
-        this.datafileVersion = datafileVersion;
+    public OptimizelyTest(String validDatafile, String noAudienceDatafile) throws ConfigParseException {
         this.validDatafile = validDatafile;
         this.noAudienceDatafile = noAudienceDatafile;
-        this.validProjectConfig = validProjectConfig;
-        this.noAudienceProjectConfig = noAudienceProjectConfig;
+
+        this.validProjectConfig = new ProjectConfig.Builder().withDatafile(validDatafile).build();
+        this.noAudienceProjectConfig = new ProjectConfig.Builder().withDatafile(noAudienceDatafile).build();
+
+        // FIX-ME
+        //assertEquals(validProjectConfig.getVersion(), noAudienceProjectConfig.getVersion());
+
+        this.datafileVersion = Integer.parseInt(validProjectConfig.getVersion());
     }
 
     //======== activate tests ========//
@@ -189,7 +181,6 @@ public void activateEndToEnd() throws Exception {
             .withErrorHandler(mockErrorHandler)
             .build();
 
-
         when(mockEventFactory.createImpressionEvent(validProjectConfig, activatedExperiment, bucketedVariation, testUserId,
             testUserAttributes))
             .thenReturn(logEventToDispatch);
@@ -208,6 +199,9 @@ public void activateEndToEnd() throws Exception {
         logbackVerifier.expectMessage(Level.DEBUG, "Dispatching impression event to URL test_url with params " +
             testParams + " and payload \"{}\"");
 
+        // Force variation to null to get expected log output.
+        optimizely.setForcedVariation(activatedExperiment.getKey(), testUserId, null);
+
         // activate the experiment
         Variation actualVariation = optimizely.activate(activatedExperiment.getKey(), userId, testUserAttributes);
 
@@ -267,6 +261,9 @@ public void activateEndToEndWithTypedAudienceInt() throws Exception {
         logbackVerifier.expectMessage(Level.DEBUG, "Dispatching impression event to URL test_url with params " +
             testParams + " and payload \"{}\"");
 
+        // Force variation to null to get expected log output.
+        optimizely.setForcedVariation(activatedExperiment.getKey(), testUserId, null);
+
         // activate the experiment
         Variation actualVariation = optimizely.activate(activatedExperiment.getKey(), userId, testUserAttributes);
 
@@ -418,6 +415,9 @@ public void activateEndToEndWithTypedAudienceBool() throws Exception {
         logbackVerifier.expectMessage(Level.DEBUG, "Dispatching impression event to URL test_url with params " +
             testParams + " and payload \"{}\"");
 
+        // Force variation to null to get expected log output.
+        optimizely.setForcedVariation(activatedExperiment.getKey(), testUserId, null);
+
         // activate the experiment
         Variation actualVariation = optimizely.activate(activatedExperiment.getKey(), userId, testUserAttributes);
 
@@ -477,6 +477,9 @@ public void activateEndToEndWithTypedAudienceDouble() throws Exception {
         logbackVerifier.expectMessage(Level.DEBUG, "Dispatching impression event to URL test_url with params " +
             testParams + " and payload \"{}\"");
 
+        // Force variation to null to get expected log output.
+        optimizely.setForcedVariation(activatedExperiment.getKey(), testUserId, null);
+
         // activate the experiment
         Variation actualVariation = optimizely.activate(activatedExperiment.getKey(), userId, testUserAttributes);
 
@@ -585,6 +588,9 @@ public void activateEndToEndWithTypedAudienceWithAnd() throws Exception {
         logbackVerifier.expectMessage(Level.DEBUG, "Dispatching impression event to URL test_url with params " +
             testParams + " and payload \"{}\"");
 
+        // Force variation to null to get expected log output.
+        optimizely.setForcedVariation(activatedExperiment.getKey(), testUserId, null);
+
         // activate the experiment
         Variation actualVariation = optimizely.activate(activatedExperiment.getKey(), userId, testUserAttributes);
 
@@ -1538,6 +1544,9 @@ public void activateLaunchedExperimentDoesNotDispatchEvent() throws Exception {
         when(mockBucketer.bucket(launchedExperiment, testUserId))
             .thenReturn(launchedExperiment.getVariations().get(0));
 
+        // Force variation to launched experiment.
+        optimizely.setForcedVariation(launchedExperiment.getKey(), testUserId, expectedVariation.getKey());
+
         logbackVerifier.expectMessage(Level.INFO,
             "Experiment has \"Launched\" status so not dispatching event during activation.");
         Variation variation = optimizely.activate(launchedExperiment.getKey(), testUserId);