Skip to content

Commit 97fd046

Browse files
update: refactor CmabClientConfig to include cmabEndpoint handling and add factory method
1 parent 48ed1a2 commit 97fd046

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

core-api/src/main/java/com/optimizely/ab/Optimizely.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@
1717

1818
import com.optimizely.ab.annotations.VisibleForTesting;
1919
import com.optimizely.ab.bucketing.*;
20-
import com.optimizely.ab.cmab.service.CmabCacheValue;
2120
import com.optimizely.ab.cmab.service.CmabService;
22-
import com.optimizely.ab.cmab.service.DefaultCmabService;
2321
import com.optimizely.ab.config.AtomicProjectConfigManager;
2422
import com.optimizely.ab.config.DatafileProjectConfig;
2523
import com.optimizely.ab.config.EventType;
@@ -82,7 +80,6 @@
8280
import java.util.Map;
8381
import java.util.concurrent.locks.ReentrantLock;
8482

85-
import com.optimizely.ab.cmab.client.CmabClient;
8683
import static com.optimizely.ab.internal.SafetyUtils.tryClose;
8784

8885
/**

core-api/src/main/java/com/optimizely/ab/cmab/client/CmabClientConfig.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ public CmabClientConfig(@Nullable RetryConfig retryConfig) {
2929
this.retryConfig = retryConfig;
3030
}
3131

32+
public CmabClientConfig(@Nullable RetryConfig retryConfig, @Nullable String cmabEndpoint) {
33+
this.retryConfig = retryConfig;
34+
this.cmabEndpoint = cmabEndpoint;
35+
}
36+
3237
@Nullable
3338
public RetryConfig getRetryConfig() {
3439
return retryConfig;
@@ -60,4 +65,13 @@ public static CmabClientConfig withDefaultRetry() {
6065
public static CmabClientConfig withNoRetry() {
6166
return new CmabClientConfig(null);
6267
}
68+
69+
/**
70+
* Creates a config with custom cmab endpoint.
71+
*
72+
* @return A cmab client config with custom cmab endpoint
73+
*/
74+
public static CmabClientConfig withCmabEndpoint(@Nullable String cmabEndpoint) {
75+
return new CmabClientConfig(RetryConfig.defaultConfig(), cmabEndpoint);
76+
}
6377
}

0 commit comments

Comments
 (0)