fix: correct error returned when SDK key is invalid (#203)

* fix: correct error returned when SDK key is invalid

Author: pawels-optimizely

pkg/client/client.go

@@ -400,7 +400,6 @@ func (o *OptimizelyClient) getExperimentDecision(experimentKey string, userConte
 
 	projectConfig, e := o.GetProjectConfig()
 	if e != nil {
-		logger.Error("Error calling getExperimentDecision", e)
 		return decisionContext, experimentDecision, e
 	}
 

pkg/config/polling_manager.go

@@ -29,6 +29,8 @@ import (
 	"github.com/optimizely/go-sdk/pkg/notification"
 	"github.com/optimizely/go-sdk/pkg/registry"
 	"github.com/optimizely/go-sdk/pkg/utils"
+
+	"github.com/pkg/errors"
 )
 
 // DefaultPollingInterval sets default interval for polling manager
@@ -112,9 +114,10 @@ func (cm *PollingProjectConfigManager) SyncConfig(sdkKey string, datafile []byte
 		}
 
 		if e != nil {
-			cmLogger.Error(fmt.Sprintf("request returned with http code=%d", code), e)
+			msg := "unable to fetch fresh datafile"
+			cmLogger.Warning(msg)
 			cm.configLock.Lock()
-			closeMutex(e)
+			closeMutex(errors.New(fmt.Sprintf("%s, reason (http status code): %s", msg, e.Error())))
 			return
 		}
 
@@ -137,7 +140,7 @@ func (cm *PollingProjectConfigManager) SyncConfig(sdkKey string, datafile []byte
 	cm.configLock.Lock()
 
 	if err != nil {
-		cmLogger.Error("failed to create project config", err)
+		cmLogger.Warning("failed to create project config")
 		closeMutex(err)
 		return
 	}