Httpclient issue - object initializing multiple times (fixed) and usi… (#36)

* Httpclient issue - object initializing multiple times (fixed) and using default timeout.

* non-default timeout removed.

Author: msohailhussain

OptimizelySDK/Event/Dispatcher/HttpClientEventDispatcher45.cs

@@ -26,9 +26,17 @@ public class HttpClientEventDispatcher45 : IEventDispatcher
         public ILogger Logger { get; set; } = new DefaultLogger();
 
         /// <summary>
-        /// Timeout for the HTTP request (10 seconds)
+        /// HTTP client object.
         /// </summary>
-        const int TIMEOUT_MS = 10000;
+        private static readonly HttpClient Client;
+
+        /// <summary>
+        /// Constructor for initializing static members.
+        /// </summary>
+        static HttpClientEventDispatcher45()
+        {
+            Client = new HttpClient();
+        }
 
         /// <summary>
         /// Dispatch an Event asynchronously
@@ -38,26 +46,20 @@ private async void DispatchEventAsync(LogEvent logEvent)
             try
             {
                 string json = logEvent.GetParamsAsJson();
-
-                using (var client = new HttpClient())
+                var request = new HttpRequestMessage
                 {
-                    client.Timeout = TimeSpan.FromMilliseconds(TIMEOUT_MS);
-
-                    var request = new HttpRequestMessage
-                    {
-                        RequestUri = new Uri(logEvent.Url),
-                        Method = HttpMethod.Post,
-                        // The Content-Type header applies to the Content, not the Request itself
-                        Content = new StringContent(json, System.Text.Encoding.UTF8, "application/json"),
-                    };
+                    RequestUri = new Uri(logEvent.Url),
+                    Method = HttpMethod.Post,
+                    // The Content-Type header applies to the Content, not the Request itself
+                    Content = new StringContent(json, System.Text.Encoding.UTF8, "application/json"),
+                };
 
-                    foreach (var h in logEvent.Headers)
-                        if (h.Key.ToLower() != "content-type")
-                            request.Content.Headers.Add(h.Key, h.Value);
+                foreach (var h in logEvent.Headers)
+                    if (h.Key.ToLower() != "content-type")
+                        request.Content.Headers.Add(h.Key, h.Value);
 
-                    var result = await client.SendAsync(request);
-                    result.EnsureSuccessStatusCode();
-                }
+                var result = await Client.SendAsync(request);
+                result.EnsureSuccessStatusCode();
             }
             catch (Exception ex)
             {

OptimizelySDK/Event/Dispatcher/WebRequestEventDispatcher35.cs

@@ -25,11 +25,6 @@ public class WebRequestClientEventDispatcher35 : IEventDispatcher
         // TODO Catch and Log Errors
         public Logger.ILogger Logger { get; set; }
 
-        /// <summary>
-        /// Timeout for the HTTP request (10 seconds)
-        /// </summary>
-        private const int TIMEOUT_MS = 10000;
-
         private HttpWebRequest Request = null;
 
         /// <summary>
@@ -43,7 +38,6 @@ public void DispatchEvent(LogEvent logEvent)
             Request = (HttpWebRequest)WebRequest.Create(logEvent.Url);
 
             Request.UserAgent = "Optimizely-csharp-SDKv01";
-            Request.Timeout = TIMEOUT_MS;
             Request.Method = logEvent.HttpVerb;
 
             foreach (var h in logEvent.Headers)