[FSSDK-11177] review update 2

Author: junaed-optimizely

OptimizelySDK/Bucketing/DecisionService.cs

@@ -815,6 +815,17 @@ public virtual Result<FeatureDecision> GetVariationForFeatureExperiment(
                     decisionVariation = variationResult?.Variation;
 #if USE_CMAB
                     cmabUuid = variationResult?.CmabUuid;
+                    
+                    if (variationResult?.CmabError == true)
+                    {
+                        Logger.Log(LogLevel.ERROR,
+                            reasons.AddInfo(
+                                $"Failed to fetch CMAB decision for user \"{userId}\" in experiment \"{experiment.Key}\" of feature \"{featureFlag.Key}\"."));
+                        
+                        var errorDecision = new FeatureDecision(experiment, null,
+                            FeatureDecision.DECISION_SOURCE_FEATURE_TEST, null, error: true);
+                        return Result<FeatureDecision>.NewResult(errorDecision, reasons);
+                    }
 #endif
                 }
 
@@ -825,7 +836,6 @@ public virtual Result<FeatureDecision> GetVariationForFeatureExperiment(
                             $"The user \"{userId}\" is bucketed into experiment \"{experiment.Key}\" of feature \"{featureFlag.Key}\"."));
 
 #if USE_CMAB
-                    // Extract CmabUuid from VariationDecisionResult
                     var featureDecision = new FeatureDecision(experiment, decisionVariation,
                         FeatureDecision.DECISION_SOURCE_FEATURE_TEST, cmabUuid);
 #else

OptimizelySDK/Entity/FeatureDecision.cs

@@ -25,13 +25,15 @@ public class FeatureDecision
         public Variation Variation { get; }
         public string Source { get; }
         public string CmabUuid { get; }
+        public bool Error { get; }
 
-        public FeatureDecision(ExperimentCore experiment, Variation variation, string source, string cmabUuid = null)
+        public FeatureDecision(ExperimentCore experiment, Variation variation, string source, string cmabUuid = null, bool error = false)
         {
             Experiment = experiment;
             Variation = variation;
             Source = source;
             CmabUuid = cmabUuid;
+            Error = error;
         }
     }
 }

OptimizelySDK/Optimizely.cs

@@ -1043,6 +1043,27 @@ internal Dictionary<string, OptimizelyDecision> DecideForKeys(OptimizelyUserCont
                 var flagDecision = flagDecisions[key];
                 var decisionReasons = decisionReasonsMap[key];
 
+                if (flagDecision?.Error == true)
+                {
+                    var includeReasons = allOptions.Contains(OptimizelyDecideOption.INCLUDE_REASONS);
+                    var reasonsToReport = decisionReasons.ToReport(includeReasons).ToArray();
+                    
+                    var errorDecision = OptimizelyDecision.NewErrorDecision(
+                        key,
+                        user,
+                        reasonsToReport,
+                        ErrorHandler,
+                        Logger
+                    );
+                    
+                    if (!allOptions.Contains(OptimizelyDecideOption.ENABLED_FLAGS_ONLY) ||
+                        errorDecision.Enabled)
+                    {
+                        decisionDictionary.Add(key, errorDecision);
+                    }
+                    continue;
+                }
+
                 var optimizelyDecision = CreateOptimizelyDecision(user, key, flagDecision,
                     decisionReasons, allOptions.ToList(), projectConfig);
                 if (!allOptions.Contains(OptimizelyDecideOption.ENABLED_FLAGS_ONLY) ||

OptimizelySDK/OptimizelyDecisions/OptimizelyDecision.cs

@@ -107,5 +107,28 @@ ILogger logger
                 optimizelyUserContext,
                 new string[] { error });
         }
+
+        /// <summary>
+        /// Static function to return OptimizelyDecision with multiple error reasons.
+        /// Similar to the single error overload but accepts an array of reasons.
+        /// OptimizelyDecision will have null variation key, false enabled, empty variables, null rule key
+        /// and the provided reasons array.
+        /// </summary>
+        public static OptimizelyDecision NewErrorDecision(string key,
+            OptimizelyUserContext optimizelyUserContext,
+            string[] reasons,
+            IErrorHandler errorHandler,
+            ILogger logger
+        )
+        {
+            return new OptimizelyDecision(
+                null,
+                false,
+                new OptimizelyJSON(new Dictionary<string, object>(), errorHandler, logger),
+                null,
+                key,
+                optimizelyUserContext,
+                reasons);
+        }
     }
 }