[FSSDK-11177] decision service update

Author: junaed-optimizely

OptimizelySDK.Tests/CmabTests/DecisionServiceCmabTest.cs

@@ -629,10 +629,7 @@ private Experiment CreateCmabExperiment(string id, string key, int trafficAlloca
                 Status = "Running",
                 TrafficAllocation = new TrafficAllocation[0],
                 ForcedVariations = new Dictionary<string, string>(), // UserIdToKeyVariations is an alias for this
-                Cmab = new Entity.Cmab(attributeIds ?? new List<string>())
-                {
-                    TrafficAllocation = trafficAllocation
-                }
+                Cmab = new Entity.Cmab(attributeIds ?? new List<string>(), trafficAllocation)
             };
         }
 

OptimizelySDK.Tests/CmabTests/DefaultCmabServiceTest.cs

@@ -649,7 +649,7 @@ private static Experiment CreateExperiment(string ruleId, List<string> attribute
             return new Experiment
             {
                 Id = ruleId,
-                Cmab = attributeIds == null ? null : new Entity.Cmab(attributeIds),
+                Cmab = attributeIds == null ? null : new Entity.Cmab(attributeIds, 10000),
             };
         }
 

OptimizelySDK.Tests/CmabTests/OptimizelyUserContextCmabTest.cs

@@ -517,11 +517,8 @@ private void ConfigureCmabExperiment(ProjectConfig config,
 
             Assert.IsNotNull(experiment, $"Experiment {experimentKey} should exist for CMAB tests.");
 
-            experiment.Cmab = new Entity.Cmab(attributeList)
-            {
-                TrafficAllocation = trafficAllocation
-            };
-
+            experiment.Cmab = new Entity.Cmab(attributeList, trafficAllocation);
+                
             config.ExperimentIdMap[experiment.Id] = experiment;
             if (config.ExperimentKeyMap.ContainsKey(experiment.Key))
             {

OptimizelySDK/Bucketing/DecisionService.cs

@@ -312,23 +312,13 @@ OptimizelyDecideOption[] options
             var reasons = new DecisionReasons();
             var userId = user.GetUserId();
 
-            // Check if CMAB is properly configured
-            if (experiment.Cmab == null)
-            {
-                var message = string.Format(CmabConstants.CMAB_EXPERIMENT_NOT_PROPERLY_CONFIGURED,
-                    experiment.Key);
-                Logger.Log(LogLevel.ERROR, reasons.AddInfo(message));
-                return Result<VariationDecisionResult>.NewResult(
-                    new VariationDecisionResult(null, null, true), reasons);
-            }
-
             // Create dummy traffic allocation for CMAB
             var cmabTrafficAllocation = new List<TrafficAllocation>
             {
                 new TrafficAllocation
                 {
                     EntityId = "$",
-                    EndOfRange = experiment.Cmab.TrafficAllocation ?? 0,
+                    EndOfRange = experiment.Cmab.TrafficAllocation,
                 },
             };
 
@@ -347,27 +337,10 @@ OptimizelyDecideOption[] options
                     new VariationDecisionResult(null), reasons);
             }
 
-            // User is in CMAB traffic allocation, fetch decision from CMAB service
-            if (CmabService == null)
-            {
-                var message = "CMAB service is not initialized.";
-                Logger.Log(LogLevel.ERROR, reasons.AddInfo(message));
-                return Result<VariationDecisionResult>.NewResult(
-                    new VariationDecisionResult(null, null, true), reasons);
-            }
-
             try
             {
                 var cmabDecision = CmabService.GetDecision(config, user, experiment.Id, options);
 
-                if (cmabDecision == null || string.IsNullOrEmpty(cmabDecision.VariationId))
-                {
-                    var message = string.Format(CmabConstants.CMAB_FETCH_FAILED, experiment.Key);
-                    Logger.Log(LogLevel.ERROR, reasons.AddInfo(message));
-                    return Result<VariationDecisionResult>.NewResult(
-                        new VariationDecisionResult(null, null, true), reasons);
-                }
-
                 // Get the variation from the project config
                 var variation = config.GetVariationFromIdByExperimentId(experiment.Id,
                     cmabDecision.VariationId);

OptimizelySDK/Entity/Cmab.cs

@@ -36,14 +36,14 @@ public class Cmab
         /// Determines what portion of traffic should be allocated to CMAB decision making.
         /// </summary>
         [JsonProperty("trafficAllocation")]
-        public int? TrafficAllocation { get; set; }
+        public int TrafficAllocation { get; set; }
 
         /// <summary>
         /// Initializes a new instance of the Cmab class with specified values.
         /// </summary>
         /// <param name="attributeIds">List of attribute IDs for CMAB</param>
         /// <param name="trafficAllocation">Traffic allocation value</param>
-        public Cmab(List<string> attributeIds, int? trafficAllocation = null)
+        public Cmab(List<string> attributeIds, int trafficAllocation)
         {
             AttributeIds = attributeIds ?? new List<string>();
             TrafficAllocation = trafficAllocation;