[FSSDK-11547] fsc fix attempt 1

Author: junaed-optimizely

OptimizelySDK/Bucketing/DecisionService.cs

@@ -759,7 +759,7 @@ public virtual Result<FeatureDecision> GetDecisionForFlag(
             var userId = user.GetUserId();
 
             // Check holdouts first (highest priority)
-            var holdouts = projectConfig.GetHoldoutsForFlag(featureFlag.Key);
+            var holdouts = projectConfig.GetHoldoutsForFlag(featureFlag.Id);
             foreach (var holdout in holdouts)
             {
                 var holdoutDecision = GetVariationForHoldout(holdout, user, projectConfig);
@@ -945,7 +945,7 @@ ProjectConfig config
             var bucketedVariation = Bucketer.Bucket(config, holdout, bucketingIdResult.ResultObject, userId);
             reasons += bucketedVariation.DecisionReasons;
 
-            if (bucketedVariation.ResultObject != null)
+            if (bucketedVariation.ResultObject != null && !string.IsNullOrEmpty(bucketedVariation.ResultObject.Key))
             {
                 reasons.AddInfo($"User \"{userId}\" is bucketed into holdout variation \"{bucketedVariation.ResultObject.Key}\".");
                 return Result<FeatureDecision>.NewResult(

OptimizelySDK/Config/DatafileProjectConfig.cs

@@ -875,13 +875,13 @@ public string ToDatafile()
         }
 
         /// <summary>
-        /// Get holdout instances associated with the given feature flag key.
+        /// Get holdout instances associated with the given feature flag Id.
         /// </summary>
-        /// <param name="flagKey">Feature flag key</param>
+        /// <param name="flagId">Feature flag Id</param>
         /// <returns>Array of holdouts associated with the flag, empty array if none</returns>
-        public Holdout[] GetHoldoutsForFlag(string flagKey)
+        public Holdout[] GetHoldoutsForFlag(string flagId)
         {
-            var holdouts = _holdoutConfig?.GetHoldoutsForFlag(flagKey);
+            var holdouts = _holdoutConfig?.GetHoldoutsForFlag(flagId);
             return holdouts?.ToArray() ?? new Holdout[0];
         }
         /// Returns the datafile corresponding to ProjectConfig

OptimizelySDK/ProjectConfig.cs

@@ -321,11 +321,11 @@ public interface ProjectConfig
         Holdout GetHoldout(string holdoutId);
 
         /// <summary>
-        /// Get holdout instances associated with the given feature flag key.
+        /// Get holdout instances associated with the given feature flag Id.
         /// </summary>
-        /// <param name="flagKey">Feature flag key</param>
+        /// <param name="flagKey">Feature flag Id</param>
         /// <returns>Array of holdouts associated with the flag, empty array if none</returns>
-        Holdout[] GetHoldoutsForFlag(string flagKey);
+        Holdout[] GetHoldoutsForFlag(string flagId);
 
         /// <summary>
         /// Returns the datafile corresponding to ProjectConfig