Skip to content

Commit 28a860a

Browse files
msohailhussainaliabbasrizvi
msohailhussain
authored and
aliabbasrizvi
committed
Feature variable fix. Instead of enum representing with integer value, we need actual descriptive value (#155)
1 parent a12b794 commit 28a860a

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

‎OptimizelySDK.Tests/OptimizelyTest.cs‎

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,11 @@ public class OptimizelyTest
5454
private Variation GroupVariation;
5555
private Optimizely OptimizelyWithTypedAudiences;
5656

57+
const string FEATUREVARIABLE_BOOLEANTYPE = "boolean";
58+
const string FEATUREVARIABLE_INTEGERTYPE = "integer";
59+
const string FEATUREVARIABLE_DOUBLETYPE = "double";
60+
const string FEATUREVARIABLE_STRINGTYPE = "string";
61+
5762
#region Test Life Cycle
5863
[SetUp]
5964
public void Initialize()
@@ -2474,7 +2479,7 @@ public void TestGetFeatureVariableDoubleSendsNotificationWhenUserBuckedIntoFeatu
24742479
{ "featureEnabled", true },
24752480
{ "variableKey", variableKey },
24762481
{ "variableValue", expectedValue },
2477-
{ "variableType", FeatureVariable.VariableType.DOUBLE },
2482+
{ "variableType", FEATUREVARIABLE_DOUBLETYPE },
24782483
{ "source", FeatureDecision.DECISION_SOURCE_EXPERIMENT },
24792484
{ "sourceExperimentKey", "test_experiment_double_feature" },
24802485
{ "sourceVariationKey", "control" },
@@ -2518,7 +2523,7 @@ public void TestGetFeatureVariableIntegerSendsNotificationWhenUserBuckedIntoFeat
25182523
{ "featureEnabled", true },
25192524
{ "variableKey", variableKey },
25202525
{ "variableValue", expectedValue },
2521-
{ "variableType", FeatureVariable.VariableType.INTEGER },
2526+
{ "variableType", FEATUREVARIABLE_INTEGERTYPE },
25222527
{ "source", FeatureDecision.DECISION_SOURCE_EXPERIMENT },
25232528
{ "sourceExperimentKey", "test_experiment_integer_feature" },
25242529
{ "sourceVariationKey", "variation" },
@@ -2556,7 +2561,7 @@ public void TestGetFeatureVariableDoubleSendsNotificationWhenUserBuckedIntoFeatu
25562561
{ "featureEnabled", false },
25572562
{ "variableKey", variableKey },
25582563
{ "variableValue", expectedValue },
2559-
{ "variableType", FeatureVariable.VariableType.DOUBLE },
2564+
{ "variableType", FEATUREVARIABLE_DOUBLETYPE },
25602565
{ "source", FeatureDecision.DECISION_SOURCE_EXPERIMENT },
25612566
{ "sourceExperimentKey", "test_experiment_double_feature" },
25622567
{ "sourceVariationKey", "variation" },
@@ -2600,7 +2605,7 @@ public void TestGetFeatureVariableIntegerSendsNotificationWhenUserBuckedIntoFeat
26002605
{ "featureEnabled", false },
26012606
{ "variableKey", variableKey },
26022607
{ "variableValue", expectedValue },
2603-
{ "variableType", FeatureVariable.VariableType.INTEGER },
2608+
{ "variableType", FEATUREVARIABLE_INTEGERTYPE },
26042609
{ "source", FeatureDecision.DECISION_SOURCE_EXPERIMENT },
26052610
{ "sourceExperimentKey", "test_experiment_integer_feature" },
26062611
{ "sourceVariationKey", "control" },
@@ -2638,7 +2643,7 @@ public void TestGetFeatureVariableBooleanSendsNotificationWhenUserBuckedIntoRoll
26382643
{ "featureEnabled", true },
26392644
{ "variableKey", variableKey },
26402645
{ "variableValue", expectedValue },
2641-
{ "variableType", FeatureVariable.VariableType.BOOLEAN },
2646+
{ "variableType", FEATUREVARIABLE_BOOLEANTYPE },
26422647
{ "source", FeatureDecision.DECISION_SOURCE_ROLLOUT },
26432648
{ "sourceExperimentKey", null },
26442649
{ "sourceVariationKey", null },
@@ -2682,7 +2687,7 @@ public void TestGetFeatureVariableStringSendsNotificationWhenUserBuckedIntoRollo
26822687
{ "featureEnabled", true },
26832688
{ "variableKey", variableKey },
26842689
{ "variableValue", expectedValue },
2685-
{ "variableType", FeatureVariable.VariableType.STRING },
2690+
{ "variableType", FEATUREVARIABLE_STRINGTYPE },
26862691
{ "source", FeatureDecision.DECISION_SOURCE_ROLLOUT },
26872692
{ "sourceExperimentKey", null },
26882693
{ "sourceVariationKey", null },
@@ -2720,7 +2725,7 @@ public void TestGetFeatureVariableBooleanSendsNotificationWhenUserBuckedIntoRoll
27202725
{ "featureEnabled", false },
27212726
{ "variableKey", variableKey },
27222727
{ "variableValue", expectedValue },
2723-
{ "variableType", FeatureVariable.VariableType.BOOLEAN },
2728+
{ "variableType", FEATUREVARIABLE_BOOLEANTYPE },
27242729
{ "source", FeatureDecision.DECISION_SOURCE_ROLLOUT },
27252730
{ "sourceExperimentKey", null },
27262731
{ "sourceVariationKey", null },
@@ -2764,7 +2769,7 @@ public void TestGetFeatureVariableStringSendsNotificationWhenUserBuckedIntoRollo
27642769
{ "featureEnabled", false },
27652770
{ "variableKey", variableKey },
27662771
{ "variableValue", expectedValue },
2767-
{ "variableType", FeatureVariable.VariableType.STRING },
2772+
{ "variableType", FEATUREVARIABLE_STRINGTYPE },
27682773
{ "source", FeatureDecision.DECISION_SOURCE_ROLLOUT },
27692774
{ "sourceExperimentKey", null },
27702775
{ "sourceVariationKey", null },
@@ -2800,7 +2805,7 @@ public void TestGetFeatureVariableDoubleSendsNotificationWhenUserNotBuckedIntoBo
28002805
{ "featureEnabled", false },
28012806
{ "variableKey", variableKey },
28022807
{ "variableValue", expectedValue },
2803-
{ "variableType", FeatureVariable.VariableType.DOUBLE },
2808+
{ "variableType", FEATUREVARIABLE_DOUBLETYPE },
28042809
{ "source", FeatureDecision.DECISION_SOURCE_ROLLOUT },
28052810
{ "sourceExperimentKey", null },
28062811
{ "sourceVariationKey", null },

‎OptimizelySDK/Optimizely.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ public virtual T GetFeatureVariableValueForType<T>(string featureKey, string var
509509
{ "featureEnabled", featureEnabled },
510510
{ "variableKey", variableKey },
511511
{ "variableValue", typeCastedValue },
512-
{ "variableType", variableType },
512+
{ "variableType", variableType.ToString().ToLower() },
513513
{ "source", decision?.Source },
514514
{ "sourceExperimentKey", experimentKey },
515515
{ "sourceVariationKey", variationKey },

0 commit comments

Comments
 (0)