[FSSDK-9090] Default instantiation of OdpManager for Optimizely constructors (#347)

* Add default OdpManager for Optimizely constructor

* Fix linter error

* Fix linter error seriously this time

* Linting OptimizelyTest too

* Fix brittle, commonly-failing tests

* Grrr lint fix

* Fix lints

Need to auto-run lint fixes on commit

* Lint fixes need to be refined

* Fix linting settings & use during CI

* Fix EDITORCONFIG_FILE_NAME

* Correct path to .edtiorconfig?

* Use GITHUB_WORKSPACE to .editorconfig

* dotnet-format automatically looks for .editorconfig in repo root

Author: mikechu-optimizely

.editorconfig

@@ -95,8 +95,9 @@ csharp_preferred_modifier_order = public, private, protected, internal, static,
 csharp_prefer_braces = true:silent
 csharp_style_deconstructed_variable_declaration = true:suggestion
 csharp_prefer_simple_default_expression = true:suggestion
-csharp_style_prefer_local_over_anonymous_function = true:suggestion
 csharp_style_inlined_variable_declaration = true:suggestion
+# 'using' directive placement
+csharp_using_directive_placement = outside_namespace
 ###############################
 # C# Formatting Rules         #
 ###############################

.github/workflows/csharp.yml

@@ -28,7 +28,7 @@ jobs:
           VALIDATE_ALL_CODEBASE: false
           DEFAULT_BRANCH: master
           VALIDATE_CSHARP: true
-
+          
   integration_tests:
     name: Run Integration Tests
     uses: optimizely/csharp-sdk/.github/workflows/integration_test.yml@master

OptimizelySDK.Tests/ConfigTest/PollingProjectConfigManagerTest.cs

@@ -68,6 +68,7 @@ public void TestPollingConfigManagerBlocksWhenProjectConfigIsNotProvided()
                 {
                     POLL_EVERY_MILLISECONDS,
                 });
+            configManager.Start();
 
             stopwatch.Start();
             configManager.GetConfig();

OptimizelySDK.Tests/NotificationTests/NotificationCenterTests.cs

@@ -1,5 +1,5 @@
 /* 
- * Copyright 2017, 2019, Optimizely
+ * Copyright 2017, 2019, 2023, Optimizely
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,6 +16,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Threading;
 using Moq;
 using NUnit.Framework;
 using OptimizelySDK.Config;
@@ -332,8 +333,10 @@ Dictionary<string, object> decisionInfo
 
         public virtual void TestConfigUpdateCallback() { }
 
+        public virtual void TestConfigUpdateCallback(CountdownEvent cde) { cde.Signal(); }
+
         public virtual void TestLogEventCallback(LogEvent logEvent) { }
     }
 
-    #endregion // Test Notification callbacks class.
+    #endregion
 }