♻️ Refactor: Share cache transform function between components

Extract the stripManagedFieldsAndAnnotations function to a shared
utility package to eliminate code duplication between operator-controller
and catalogd.

Changes:
- Created internal/shared/util/cache/transform.go with
  StripManagedFieldsAndAnnotations function
- Updated cmd/operator-controller/main.go to use shared implementation
- Updated cmd/catalogd/main.go to use shared implementation
- Removed duplicate function definitions (46 lines of duplication removed)

This improves maintainability by having a single source of truth for
the cache transform logic used across both components.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: tmshort

cmd/catalogd/main.go

@@ -59,6 +59,7 @@ import (
 	"github.com/operator-framework/operator-controller/internal/catalogd/storage"
 	"github.com/operator-framework/operator-controller/internal/catalogd/webhook"
 	sharedcontrollers "github.com/operator-framework/operator-controller/internal/shared/controllers"
+	cacheutil "github.com/operator-framework/operator-controller/internal/shared/util/cache"
 	fsutil "github.com/operator-framework/operator-controller/internal/shared/util/fs"
 	httputil "github.com/operator-framework/operator-controller/internal/shared/util/http"
 	imageutil "github.com/operator-framework/operator-controller/internal/shared/util/image"
@@ -255,7 +256,7 @@ func run(ctx context.Context) error {
 	cacheOptions := crcache.Options{
 		ByObject: map[client.Object]crcache.ByObject{},
 		// Memory optimization: strip managed fields and large annotations from cached objects
-		DefaultTransform: stripManagedFieldsAndAnnotations,
+		DefaultTransform: cacheutil.StripManagedFieldsAndAnnotations,
 	}
 
 	saKey, err := sautil.GetServiceAccount()
@@ -452,28 +453,6 @@ func run(ctx context.Context) error {
 	return nil
 }
 
-// stripManagedFieldsAndAnnotations is a cache transform function that removes
-// memory-heavy fields that aren't needed for controller operations.
-// This significantly reduces memory usage in informer caches.
-func stripManagedFieldsAndAnnotations(obj interface{}) (interface{}, error) {
-	if metaObj, ok := obj.(client.Object); ok {
-		// Remove managed fields - these can be several KB per object
-		metaObj.SetManagedFields(nil)
-
-		// Remove the last-applied-configuration annotation which can be very large
-		annotations := metaObj.GetAnnotations()
-		if annotations != nil {
-			delete(annotations, "kubectl.kubernetes.io/last-applied-configuration")
-			if len(annotations) == 0 {
-				metaObj.SetAnnotations(nil)
-			} else {
-				metaObj.SetAnnotations(annotations)
-			}
-		}
-	}
-	return obj, nil
-}
-
 func podNamespace() string {
 	namespace, err := os.ReadFile("/var/run/secrets/kubernetes.io/serviceaccount/namespace")
 	if err != nil {

cmd/operator-controller/main.go

@@ -78,6 +78,7 @@ import (
 	"github.com/operator-framework/operator-controller/internal/operator-controller/rukpak/render/registryv1"
 	"github.com/operator-framework/operator-controller/internal/operator-controller/scheme"
 	sharedcontrollers "github.com/operator-framework/operator-controller/internal/shared/controllers"
+	cacheutil "github.com/operator-framework/operator-controller/internal/shared/util/cache"
 	fsutil "github.com/operator-framework/operator-controller/internal/shared/util/fs"
 	httputil "github.com/operator-framework/operator-controller/internal/shared/util/http"
 	imageutil "github.com/operator-framework/operator-controller/internal/shared/util/image"
@@ -233,7 +234,7 @@ func run() error {
 		},
 		DefaultLabelSelector: k8slabels.Nothing(),
 		// Memory optimization: strip managed fields and large annotations from cached objects
-		DefaultTransform: stripManagedFieldsAndAnnotations,
+		DefaultTransform: cacheutil.StripManagedFieldsAndAnnotations,
 	}
 
 	if features.OperatorControllerFeatureGate.Enabled(features.BoxcutterRuntime) {
@@ -688,28 +689,6 @@ func setupHelm(
 	return nil
 }
 
-// stripManagedFieldsAndAnnotations is a cache transform function that removes
-// memory-heavy fields that aren't needed for controller operations.
-// This significantly reduces memory usage in informer caches.
-func stripManagedFieldsAndAnnotations(obj interface{}) (interface{}, error) {
-	if metaObj, ok := obj.(client.Object); ok {
-		// Remove managed fields - these can be several KB per object
-		metaObj.SetManagedFields(nil)
-
-		// Remove the last-applied-configuration annotation which can be very large
-		annotations := metaObj.GetAnnotations()
-		if annotations != nil {
-			delete(annotations, "kubectl.kubernetes.io/last-applied-configuration")
-			if len(annotations) == 0 {
-				metaObj.SetAnnotations(nil)
-			} else {
-				metaObj.SetAnnotations(annotations)
-			}
-		}
-	}
-	return obj, nil
-}
-
 func main() {
 	if err := operatorControllerCmd.Execute(); err != nil {
 		fmt.Fprintf(os.Stderr, "Error: %v\n", err)

internal/shared/util/cache/transform.go

@@ -0,0 +1,30 @@
+package cache
+
+import "sigs.k8s.io/controller-runtime/pkg/client"
+
+// StripManagedFieldsAndAnnotations is a cache transform function that removes
+// memory-heavy fields that aren't needed for controller operations.
+// This significantly reduces memory usage in informer caches by removing:
+// - Managed fields (can be several KB per object)
+// - kubectl.kubernetes.io/last-applied-configuration annotation (can be very large)
+//
+// Use this function as a DefaultTransform in controller-runtime cache.Options
+// to reduce memory overhead across all cached objects.
+func StripManagedFieldsAndAnnotations(obj interface{}) (interface{}, error) {
+	if metaObj, ok := obj.(client.Object); ok {
+		// Remove managed fields - these can be several KB per object
+		metaObj.SetManagedFields(nil)
+
+		// Remove the last-applied-configuration annotation which can be very large
+		annotations := metaObj.GetAnnotations()
+		if annotations != nil {
+			delete(annotations, "kubectl.kubernetes.io/last-applied-configuration")
+			if len(annotations) == 0 {
+				metaObj.SetAnnotations(nil)
+			} else {
+				metaObj.SetAnnotations(annotations)
+			}
+		}
+	}
+	return obj, nil
+}