feat!: retrieve ObjectMapper from ConfigurationService

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

@@ -1,6 +1,5 @@
 package io.javaoperatorsdk.operator;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import io.fabric8.kubernetes.api.model.apiextensions.v1.CustomResourceDefinition;
 import io.fabric8.kubernetes.client.CustomResource;
 import io.fabric8.kubernetes.client.KubernetesClient;
@@ -29,20 +28,11 @@ public class Operator implements AutoCloseable {
   private static final Logger log = LoggerFactory.getLogger(Operator.class);
   private final KubernetesClient k8sClient;
   private final ConfigurationService configurationService;
-  private final ObjectMapper objectMapper;
   private final List<Closeable> closeables;
 
   public Operator(KubernetesClient k8sClient, ConfigurationService configurationService) {
-    this(k8sClient, configurationService, new ObjectMapper());
-  }
-
-  public Operator(
-      KubernetesClient k8sClient,
-      ConfigurationService configurationService,
-      ObjectMapper objectMapper) {
     this.k8sClient = k8sClient;
     this.configurationService = configurationService;
-    this.objectMapper = objectMapper;
     this.closeables = new ArrayList<>();
   }
 
@@ -160,7 +150,8 @@ public <R extends CustomResource> void register(
       final var client = k8sClient.customResources(resClass);
       EventDispatcher<R> dispatcher = new EventDispatcher<>(controller, finalizer, client);
 
-      CustomResourceCache customResourceCache = new CustomResourceCache(objectMapper);
+      CustomResourceCache customResourceCache =
+          new CustomResourceCache(configurationService.getObjectMapper());
       DefaultEventHandler defaultEventHandler =
           new DefaultEventHandler(
               customResourceCache,

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java

@@ -1,5 +1,6 @@
 package io.javaoperatorsdk.operator.api.config;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
 import io.fabric8.kubernetes.client.Config;
 import io.fabric8.kubernetes.client.CustomResource;
 import io.javaoperatorsdk.operator.api.ResourceController;
@@ -57,6 +58,7 @@ default boolean checkCRDAndValidateLocalModel() {
   }
 
   int DEFAULT_RECONCILIATION_THREADS_NUMBER = 5;
+
   /**
    * Retrieves the maximum number of threads the operator can spin out to dispatch reconciliation
    * requests to controllers
@@ -66,4 +68,15 @@ default boolean checkCRDAndValidateLocalModel() {
   default int concurrentReconciliationThreads() {
     return DEFAULT_RECONCILIATION_THREADS_NUMBER;
   }
+
+  /**
+   * The {@link ObjectMapper} that the operator should use to de-/serialize resources. This is
+   * particularly useful when frameworks can configure a specific mapper that should also be used by
+   * the SDK.
+   *
+   * @return the ObjectMapper to use
+   */
+  default ObjectMapper getObjectMapper() {
+    return new ObjectMapper();
+  }
 }