remove doneableClassCache

Author: Soroosh Sarabadani

operator-framework/src/main/java/io/javaoperatorsdk/operator/ControllerUtils.java

@@ -7,41 +7,32 @@
 
 import java.lang.reflect.ParameterizedType;
 import java.util.Arrays;
-import java.util.HashMap;
-import java.util.Map;
 
 
 public class ControllerUtils {
 
     private static final String FINALIZER_NAME_SUFFIX = "/finalizer";
 
-    // this is just to support testing, this way we don't try to create class multiple times in memory with same name.
-    // note that other solution is to add a random string to doneable class name
-    private static Map<Class<? extends CustomResource>, Class<? extends CustomResourceDoneable<? extends CustomResource>>>
-            doneableClassCache = new HashMap<>();
-
     static String getFinalizer(ResourceController controller) {
         final String annotationFinalizerName = getAnnotation(controller).finalizerName();
         if (!Controller.NULL.equals(annotationFinalizerName)) {
             return annotationFinalizerName;
         }
-        final String crdName = getAnnotation(controller).crdName() + FINALIZER_NAME_SUFFIX;
-        return crdName;
+        return getAnnotation(controller).crdName() + FINALIZER_NAME_SUFFIX;
     }
 
-    static boolean getGenerationEventProcessing(ResourceController controller) {
+    static boolean getGenerationEventProcessing(ResourceController<?> controller) {
         return getAnnotation(controller).generationAwareEventProcessing();
     }
 
     static <R extends CustomResource> Class<R> getCustomResourceClass(ResourceController<R> controller) {
-        final Class<R> type = Arrays
+        return Arrays
                 .stream(controller.getClass().getGenericInterfaces())
                 .filter(i -> i instanceof ParameterizedType)
                 .map(i -> (ParameterizedType) i)
                 .findFirst()
                 .map(i -> (Class<R>) i.getActualTypeArguments()[0])
                 .get();
-        return type;
     }
 
     static String getCrdName(ResourceController controller) {
@@ -60,7 +51,7 @@ static String getCrdName(ResourceController controller) {
         }
     }
 
-    private static Controller getAnnotation(ResourceController controller) {
+    private static Controller getAnnotation(ResourceController<?> controller) {
         return controller.getClass().getAnnotation(Controller.class);
     }