feat: add impsort-maven-plugin #539

Author: lburgazzoli

.github/workflows/pr.yml

@@ -27,7 +27,9 @@ jobs:
           java-version: ${{ matrix.java }}
           cache: 'maven'
       - name: Check code format
-        run: ./mvnw ${MAVEN_ARGS} formatter:validate -Dconfigfile=$PWD/contributing/eclipse-google-style.xml --file pom.xml
+        run: |
+          ./mvnw ${MAVEN_ARGS} formatter:validate -Dconfigfile=$PWD/contributing/eclipse-google-style.xml --file pom.xml
+          ./mvnw ${MAVEN_ARGS} impsort:check --file pom.xml
       - name: Run unit tests
         run: ./mvnw ${MAVEN_ARGS} -B test --file pom.xml
       - name: Set up Minikube

.gitignore

@@ -6,6 +6,7 @@ target/
 .settings/
 .classpath
 .project
+.cache/
 
 #  VSCode
 .factorypath

contributing/eclipse.importorder

@@ -0,0 +1,7 @@
+0=java
+1=javax
+2=org
+2=io
+4=com
+5=
+6=\#

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/ControllerUtils.java

@@ -1,8 +1,9 @@
 package io.javaoperatorsdk.operator;
 
+import java.util.Locale;
+
 import io.javaoperatorsdk.operator.api.Controller;
 import io.javaoperatorsdk.operator.api.ResourceController;
-import java.util.Locale;
 
 public class ControllerUtils {
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/CustomResourceUtils.java

@@ -1,9 +1,10 @@
 package io.javaoperatorsdk.operator;
 
+import java.util.Arrays;
+
 import io.fabric8.kubernetes.api.model.Cluster;
 import io.fabric8.kubernetes.api.model.Namespaced;
 import io.fabric8.kubernetes.api.model.apiextensions.v1.CustomResourceDefinition;
-import java.util.Arrays;
 
 public abstract class CustomResourceUtils {
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/EventListUtils.java

@@ -1,9 +1,10 @@
 package io.javaoperatorsdk.operator;
 
+import java.util.List;
+
 import io.fabric8.kubernetes.client.Watcher;
 import io.javaoperatorsdk.operator.processing.event.Event;
 import io.javaoperatorsdk.operator.processing.event.internal.CustomResourceEvent;
-import java.util.List;
 
 public class EventListUtils {
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

@@ -6,7 +6,6 @@
 import java.util.Collections;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.concurrent.locks.ReentrantLock;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/Context.java

@@ -1,8 +1,9 @@
 package io.javaoperatorsdk.operator.api;
 
+import java.util.Optional;
+
 import io.fabric8.kubernetes.client.CustomResource;
 import io.javaoperatorsdk.operator.processing.event.EventList;
-import java.util.Optional;
 
 public interface Context<T extends CustomResource> {
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/DefaultContext.java

@@ -1,8 +1,9 @@
 package io.javaoperatorsdk.operator.api;
 
+import java.util.Optional;
+
 import io.fabric8.kubernetes.client.CustomResource;
 import io.javaoperatorsdk.operator.processing.event.EventList;
-import java.util.Optional;
 
 public class DefaultContext<T extends CustomResource> implements Context<T> {
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java

@@ -1,13 +1,14 @@
 package io.javaoperatorsdk.operator.api.config;
 
-import io.fabric8.kubernetes.client.CustomResource;
-import io.javaoperatorsdk.operator.ControllerUtils;
-import io.javaoperatorsdk.operator.api.ResourceController;
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Stream;
 
+import io.fabric8.kubernetes.client.CustomResource;
+import io.javaoperatorsdk.operator.ControllerUtils;
+import io.javaoperatorsdk.operator.api.ResourceController;
+
 public abstract class AbstractConfigurationService implements ConfigurationService {
   private final Map<String, ControllerConfiguration> configurations = new ConcurrentHashMap<>();
   private final Version version;