fix: avoid computing alternate value if not needed in Optionals (#1537)

Fixes #1535

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java

@@ -64,9 +64,7 @@ private LeaderCallbacks leaderCallbacks() {
     return new LeaderCallbacks(
         this::startLeading,
         this::stopLeading,
-        leader -> {
-          log.info("New leader with identity: {}", leader);
-        });
+        leader -> log.info("New leader with identity: {}", leader));
   }
 
   private void startLeading() {
@@ -82,7 +80,7 @@ private void stopLeading() {
   }
 
   private String identity(LeaderElectionConfiguration config) {
-    var id = config.getIdentity().orElse(System.getenv("HOSTNAME"));
+    var id = config.getIdentity().orElseGet(() -> System.getenv("HOSTNAME"));
     if (id == null || id.isBlank()) {
       id = UUID.randomUUID().toString();
     }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java

@@ -44,7 +44,7 @@ public ReconcileResult<R> reconcile(P primary, Context<P> context) {
         if (updatable) {
           final var match = updater.match(actual, primary, context);
           if (!match.matched()) {
-            final var desired = match.computedDesired().orElse(desired(primary, context));
+            final var desired = match.computedDesired().orElseGet(() -> desired(primary, context));
             throwIfNull(desired, primary, "Desired");
             logForOperation("Updating", primary, desired);
             var updatedResource = handleUpdate(actual, desired, primary, context);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java

@@ -165,7 +165,7 @@ private PostExecutionControl<P> handleErrorStatusHandler(P resource, P originalR
       Exception e) throws Exception {
     if (isErrorStatusHandlerPresent()) {
       try {
-        RetryInfo retryInfo = context.getRetryInfo().orElse(new RetryInfo() {
+        RetryInfo retryInfo = context.getRetryInfo().orElseGet(() -> new RetryInfo() {
           @Override
           public int getAttemptCount() {
             return 0;

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java

@@ -127,11 +127,11 @@ public Stream<T> list(String namespace, Predicate<T> predicate) {
     if (isWatchingAllNamespaces()) {
       return getSource(ALL_NAMESPACES_MAP_KEY)
           .map(source -> source.list(namespace, predicate))
-          .orElse(Stream.empty());
+          .orElseGet(Stream::empty);
     } else {
       return getSource(namespace)
           .map(source -> source.list(predicate))
-          .orElse(Stream.empty());
+          .orElseGet(Stream::empty);
     }
   }
 

sample-operators/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaReconciler.java

@@ -44,7 +44,7 @@ public UpdateControl<MySQLSchema> reconcile(MySQLSchema schema, Context<MySQLSch
           decode(secret.getData().get(MYSQL_SECRET_USERNAME)));
       log.info("Schema {} created - updating CR status", s.getName());
       return UpdateControl.patchStatus(schema);
-    }).orElse(UpdateControl.noUpdate());
+    }).orElseGet(UpdateControl::noUpdate);
   }
 
   @Override

sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/TomcatReconciler.java

@@ -36,7 +36,7 @@ public UpdateControl<Tomcat> reconcile(Tomcat tomcat, Context<Tomcat> context) {
           tomcat.getMetadata().getNamespace(),
           tomcat.getStatus().getReadyReplicas());
       return UpdateControl.patchStatus(updatedTomcat);
-    }).orElse(UpdateControl.noUpdate());
+    }).orElseGet(UpdateControl::noUpdate);
   }
 
   private Tomcat updateTomcatStatus(Tomcat tomcat, Deployment deployment) {