event list fix, unit test

Author: csviri

operator-framework/src/main/java/io/javaoperatorsdk/operator/processing/event/EventList.java

@@ -16,21 +16,12 @@ public List<Event> getList() {
     }
 
     public <T extends Event> Optional<T> getLatestOfType(Class<T> eventType) {
-        ListIterator<Event> iterator = eventList.listIterator(eventList.size() - 1);
-        while (iterator.hasPrevious()) {
-            Event event = iterator.previous();
+        for (int i = eventList.size() - 1; i >= 0; i--){
+            Event event = eventList.get(i);
             if (event.getClass().isAssignableFrom(eventType)) {
-                return Optional.of((T)event);
+                return (Optional<T>) Optional.of(event);
             }
         }
-
-        List<Event> eventsOfType = eventList.stream()
-                .filter(event -> event.getClass().isAssignableFrom(eventType))
-                .collect(Collectors.toList());
-        if (eventsOfType.size() > 0) {
-            return Optional.of((T) eventsOfType.get(eventsOfType.size() - 1));
-        } else {
-            return Optional.empty();
-        }
+        return Optional.empty();
     }
 }

operator-framework/src/test/java/io/javaoperatorsdk/operator/processing/event/EventListTest.java

@@ -0,0 +1,28 @@
+package io.javaoperatorsdk.operator.processing.event;
+
+import io.javaoperatorsdk.operator.processing.event.internal.CustomResourceEvent;
+import io.javaoperatorsdk.operator.processing.event.internal.TimerEvent;
+import org.junit.jupiter.api.Test;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import static com.google.common.truth.Truth.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.mock;
+
+class EventListTest {
+
+    @Test
+    public void returnsLatestOfEventType() {
+        TimerEvent event2 = new TimerEvent("1", null);
+        EventList eventList = new EventList(Arrays.asList(
+                mock(Event.class),
+                new TimerEvent("2", null),
+                event2,
+                mock(Event.class)));
+
+        assertThat(eventList.getLatestOfType(TimerEvent.class).get()).isSameInstanceAs(event2);
+    }
+}