feat: make debugging thread pool configurable

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ExecutorServiceProducer.java

@@ -1,10 +1,7 @@
 package io.javaoperatorsdk.operator.api.config;
 
-import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.LinkedBlockingQueue;
-import java.util.concurrent.RejectedExecutionHandler;
-import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.ThreadPoolExecutor;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicReference;
@@ -16,8 +13,7 @@ class ExecutorServiceProducer {
 
   static ExecutorService getExecutor(int threadPoolSize) {
     final var gotSet =
-        executor.compareAndSet(null, new DebugThreadPoolExecutor(threadPoolSize, threadPoolSize, 0L,
-            TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>()));
+        executor.compareAndSet(null, new InstrumentedExecutorService(threadPoolSize));
     final var result = executor.get();
     if (!gotSet) {
       // check that we didn't try to change the pool size
@@ -30,35 +26,19 @@ static ExecutorService getExecutor(int threadPoolSize) {
     return result;
   }
 
-  private static class DebugThreadPoolExecutor extends ThreadPoolExecutor {
+  private static class InstrumentedExecutorService extends ThreadPoolExecutor {
+    private final boolean debug;
 
-    public DebugThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime,
-        TimeUnit unit,
-        BlockingQueue<Runnable> workQueue) {
-      super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue);
-    }
-
-    public DebugThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime,
-        TimeUnit unit, BlockingQueue<Runnable> workQueue,
-        ThreadFactory threadFactory) {
-      super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, threadFactory);
-    }
-
-    public DebugThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime,
-        TimeUnit unit, BlockingQueue<Runnable> workQueue,
-        RejectedExecutionHandler handler) {
-      super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, handler);
-    }
-
-    public DebugThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime,
-        TimeUnit unit, BlockingQueue<Runnable> workQueue,
-        ThreadFactory threadFactory, RejectedExecutionHandler handler) {
-      super(corePoolSize, maximumPoolSize, keepAliveTime, unit, workQueue, threadFactory, handler);
+    public InstrumentedExecutorService(int corePoolSize) {
+      super(corePoolSize, corePoolSize, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<>());
+      debug = Utils.debugThreadPool();
     }
 
     @Override
     public void shutdown() {
-      Thread.dumpStack();
+      if (debug) {
+        Thread.dumpStack();
+      }
       super.shutdown();
     }
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Utils.java

@@ -13,6 +13,7 @@ public class Utils {
 
   private static final Logger log = LoggerFactory.getLogger(Utils.class);
   public static final String CHECK_CRD_ENV_KEY = "JAVA_OPERATOR_SDK_CHECK_CRD";
+  public static final String DEBUG_THREAD_POOL_ENV_KEY = "JAVA_OPERATOR_SDK_DEBUG_THREAD_POOL";
 
   /**
    * Attempts to load version information from a properties file produced at build time, currently
@@ -60,7 +61,15 @@ public static boolean isValidateCustomResourcesEnvVarSet() {
   }
 
   public static boolean shouldCheckCRDAndValidateLocalModel() {
-    final var value = System.getProperty(CHECK_CRD_ENV_KEY);
+    return getBooleanEnvProperty(CHECK_CRD_ENV_KEY);
+  }
+
+  private static boolean getBooleanEnvProperty(String envKey) {
+    final var value = System.getProperty(envKey);
     return value == null || Boolean.getBoolean(value);
   }
+
+  public static boolean debugThreadPool() {
+    return getBooleanEnvProperty(DEBUG_THREAD_POOL_ENV_KEY);
+  }
 }