feat: incompatible crd versions in test (#895)

Author: csviri

operator-framework/src/test/java/io/javaoperatorsdk/operator/MultiVersionCRDIT.java

@@ -11,12 +11,14 @@
 import io.javaoperatorsdk.operator.junit.OperatorExtension;
 import io.javaoperatorsdk.operator.sample.multiversioncrd.*;
 
+import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
 import static org.awaitility.Awaitility.await;
 
 class MultiVersionCRDIT {
 
   public static final String CR_V1_NAME = "crv1";
   public static final String CR_V2_NAME = "crv2";
+
   @RegisterExtension
   OperatorExtension operator =
       OperatorExtension.builder()
@@ -46,13 +48,38 @@ void multipleCRDVersions() {
             });
   }
 
+  @Test
+  void invalidEventsDoesNotBreakEventHandling() {
+    var v2res = createTestResourceV2WithLabel();
+    v2res.getMetadata().getLabels().clear();
+    operator.create(MultiVersionCRDTestCustomResource2.class, v2res);
+    var v1res = createTestResourceV1WithoutLabel();
+    operator.create(MultiVersionCRDTestCustomResource1.class, v1res);
+
+    await()
+        .atMost(Duration.ofSeconds(2))
+        .pollInterval(Duration.ofMillis(50))
+        .until(() -> {
+          var crV1Now = operator.get(MultiVersionCRDTestCustomResource1.class, CR_V1_NAME);
+          return crV1Now.getStatus().getReconciledBy()
+              .contains(MultiVersionCRDTestReconciler1.class.getSimpleName());
+        });
+    assertThat(
+        operator
+            .get(MultiVersionCRDTestCustomResource2.class, CR_V2_NAME)
+            .getStatus()
+            .getReconciledBy()
+            .size())
+                .isZero();
+  }
+
+
   MultiVersionCRDTestCustomResource1 createTestResourceV1WithoutLabel() {
     MultiVersionCRDTestCustomResource1 cr = new MultiVersionCRDTestCustomResource1();
     cr.setMetadata(new ObjectMeta());
     cr.getMetadata().setName(CR_V1_NAME);
     cr.setSpec(new MultiVersionCRDTestCustomResourceSpec1());
-    cr.getSpec().setValue1(1);
-    cr.getSpec().setValue2(1);
+    cr.getSpec().setValue(1);
     return cr;
   }
 
@@ -63,7 +90,7 @@ MultiVersionCRDTestCustomResource2 createTestResourceV2WithLabel() {
     cr.getMetadata().setLabels(new HashMap<>());
     cr.getMetadata().getLabels().put("version", "v2");
     cr.setSpec(new MultiVersionCRDTestCustomResourceSpec2());
-    cr.getSpec().setValue1(1);
+    cr.getSpec().setValue("string value");
     return cr;
   }
 }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiversioncrd/MultiVersionCRDTestCustomResourceSpec1.java

@@ -2,25 +2,15 @@
 
 public class MultiVersionCRDTestCustomResourceSpec1 {
 
-  private int value1;
+  private int value;
 
-  private int value2;
-
-  public int getValue1() {
-    return value1;
+  public int getValue() {
+    return value;
   }
 
-  public MultiVersionCRDTestCustomResourceSpec1 setValue1(int value1) {
-    this.value1 = value1;
+  public MultiVersionCRDTestCustomResourceSpec1 setValue(int value) {
+    this.value = value;
     return this;
   }
 
-  public int getValue2() {
-    return value2;
-  }
-
-  public MultiVersionCRDTestCustomResourceSpec1 setValue2(int value2) {
-    this.value2 = value2;
-    return this;
-  }
 }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiversioncrd/MultiVersionCRDTestCustomResourceSpec2.java

@@ -2,14 +2,14 @@
 
 public class MultiVersionCRDTestCustomResourceSpec2 {
 
-  private int value1;
+  private String value;
 
-  public int getValue1() {
-    return value1;
+  public String getValue() {
+    return value;
   }
 
-  public MultiVersionCRDTestCustomResourceSpec2 setValue1(int value1) {
-    this.value1 = value1;
+  public MultiVersionCRDTestCustomResourceSpec2 setValue(String value) {
+    this.value = value;
     return this;
   }
 }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiversioncrd/MultiVersionCRDTestCustomResourceStatus1.java

@@ -7,8 +7,6 @@ public class MultiVersionCRDTestCustomResourceStatus1 {
 
   private int value1;
 
-  private int value2;
-
   private List<String> reconciledBy = new ArrayList<>();
 
   public int getValue1() {
@@ -20,15 +18,6 @@ public MultiVersionCRDTestCustomResourceStatus1 setValue1(int value1) {
     return this;
   }
 
-  public int getValue2() {
-    return value2;
-  }
-
-  public MultiVersionCRDTestCustomResourceStatus1 setValue2(int value2) {
-    this.value2 = value2;
-    return this;
-  }
-
   public List<String> getReconciledBy() {
     return reconciledBy;
   }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiversioncrd/MultiVersionCRDTestReconciler1.java

@@ -22,7 +22,6 @@ public UpdateControl<MultiVersionCRDTestCustomResource1> reconcile(
     log.info("Reconcile MultiVersionCRDTestCustomResource1: {}",
         resource.getMetadata().getName());
     resource.getStatus().setValue1(resource.getStatus().getValue1() + 1);
-    resource.getStatus().setValue2(resource.getStatus().getValue2() + 1);
     if (!resource.getStatus().getReconciledBy().contains(getClass().getSimpleName())) {
       resource.getStatus().getReconciledBy().add(getClass().getSimpleName());
     }