Remove InputBoundRule and refactor input-bound check into SignalProvider.

PiperOrigin-RevId: 831477459

Author: Profiler Team

xprof/convert/smart_suggestion/BUILD

@@ -65,22 +65,10 @@ cc_library(
     ],
 )
 
-cc_library(
-    name = "input_bound_rule",
-    hdrs = ["input_bound_rule.h"],
-    deps = [
-        ":signal_provider",
-        ":smart_suggestion_rule",
-        "@com_google_absl//absl/status:statusor",
-        "@org_xprof//plugin/xprof/protobuf:smart_suggestion_proto_cc",
-    ],
-)
-
 cc_library(
     name = "host_processing_bound_rule",
     hdrs = ["host_processing_bound_rule.h"],
     deps = [
-        ":input_bound_rule",
         ":signal_provider",
         ":smart_suggestion_rule",
         "@com_google_absl//absl/status:statusor",
@@ -95,7 +83,6 @@ cc_library(
     name = "data_transfer_bound_rule",
     hdrs = ["data_transfer_bound_rule.h"],
     deps = [
-        ":input_bound_rule",
         ":signal_provider",
         ":smart_suggestion_rule",
         "@com_google_absl//absl/status:statusor",
@@ -194,7 +181,6 @@ cc_library(
         ":compute_bound_rule",
         ":data_transfer_bound_rule",
         ":host_processing_bound_rule",
-        ":input_bound_rule",
         ":memory_bound_rule",
         ":smart_suggestion_rule_factory",
         ":sparse_core_bound_rule",

xprof/convert/smart_suggestion/all_rules.h

@@ -20,7 +20,6 @@ limitations under the License.
 #include "xprof/convert/smart_suggestion/compute_bound_rule.h"
 #include "xprof/convert/smart_suggestion/data_transfer_bound_rule.h"
 #include "xprof/convert/smart_suggestion/host_processing_bound_rule.h"
-#include "xprof/convert/smart_suggestion/input_bound_rule.h"
 #include "xprof/convert/smart_suggestion/memory_bound_rule.h"
 #include "xprof/convert/smart_suggestion/smart_suggestion_rule_factory.h"
 #include "xprof/convert/smart_suggestion/sparse_core_bound_rule.h"
@@ -36,7 +35,6 @@ inline void RegisterAllRules(SmartSuggestionRuleFactory* f) {
   f->Register<ComputeBoundRule>();
   f->Register<DataTransferBoundRule>();
   f->Register<HostProcessingBoundRule>();
-  f->Register<InputBoundRule>();
   f->Register<MemoryBoundRule>();
   f->Register<SparseCoreBoundRule>();
   f->Register<TensorCoreIdleBoundRule>();

xprof/convert/smart_suggestion/constants.h

@@ -33,6 +33,11 @@ inline constexpr double kHbmUtilizationHighThreshold = 70.0;
 inline constexpr double kMxuUtilizationLowThreshold = 50.0;
 inline constexpr double kMxuUtilizationHighThreshold = 70.0;
 
+// Thresholds for input percentage of step time for bottleneck classification.
+// If input percentage is higher than kInfeedPercentageThreshold, it is
+// considered input bound.
+inline constexpr double kInfeedPercentageThreshold = 10.0;
+
 }  // namespace profiler
 }  // namespace tensorflow
 

xprof/convert/smart_suggestion/data_transfer_bound_rule.h

@@ -23,7 +23,6 @@ limitations under the License.
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
 #include "xla/tsl/platform/statusor.h"
-#include "xprof/convert/smart_suggestion/input_bound_rule.h"
 #include "xprof/convert/smart_suggestion/signal_provider.h"
 #include "xprof/convert/smart_suggestion/smart_suggestion_rule.h"
 #include "plugin/xprof/protobuf/smart_suggestion.pb.h"
@@ -40,8 +39,7 @@ constexpr double kDataTransferBoundThresholdInPercent = 30;
 class DataTransferBoundRule : public SmartSuggestionRule {
  protected:
   bool MeetsConditions(const SignalProvider& signal_provider) const override {
-    InputBoundRule input_bound_rule;
-    if (!input_bound_rule.MeetsConditions(signal_provider)) {
+    if (!signal_provider.IsInputBound()) {
       return false;
     }
 

xprof/convert/smart_suggestion/host_processing_bound_rule.h

@@ -23,7 +23,6 @@ limitations under the License.
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
 #include "xla/tsl/platform/statusor.h"
-#include "xprof/convert/smart_suggestion/input_bound_rule.h"
 #include "xprof/convert/smart_suggestion/signal_provider.h"
 #include "xprof/convert/smart_suggestion/smart_suggestion_rule.h"
 #include "plugin/xprof/protobuf/smart_suggestion.pb.h"
@@ -41,8 +40,7 @@ constexpr double kHostProcessingBoundThresholdInPercent = 50;
 class HostProcessingBoundRule : public SmartSuggestionRule {
  protected:
   bool MeetsConditions(const SignalProvider& signal_provider) const override {
-    InputBoundRule input_bound_rule;
-    if (!input_bound_rule.MeetsConditions(signal_provider)) {
+    if (!signal_provider.IsInputBound()) {
       return false;
     }
 

xprof/convert/smart_suggestion/input_bound_rule.h

@@ -180,6 +180,15 @@ class SignalProvider {
            *hbm_utilization < kHbmUtilizationLowThreshold;
   }
 
+  // Returns true if the input percentage of step time is above the threshold.
+  bool IsInputBound() const {
+    absl::StatusOr<double> input_percent = GetInputPercentOfStepTime();
+    if (!input_percent.ok()) {
+      return false;
+    }
+    return *input_percent > kInfeedPercentageThreshold;
+  }
+
  private:
   std::unique_ptr<ToolDataProvider> tool_data_provider_;
 };