fix: missing handler for is_eq

Author: jonathanpwang

extensions/algebra/circuit/src/modular_chip/is_eq.rs

@@ -523,6 +523,16 @@ impl<const NUM_LANES: usize, const LANE_SIZE: usize, const TOTAL_READ_SIZE: usiz
     }
 }
 
+macro_rules! dispatch {
+    ($execute_impl:ident, $is_setup:ident) => {
+        Ok(if $is_setup {
+            $execute_impl::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, true>
+        } else {
+            $execute_impl::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, false>
+        })
+    };
+}
+
 impl<F, const NUM_LANES: usize, const LANE_SIZE: usize, const TOTAL_READ_SIZE: usize> Executor<F>
     for VmModularIsEqualExecutor<NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE>
 where
@@ -540,15 +550,9 @@ where
         data: &mut [u8],
     ) -> Result<ExecuteFunc<F, Ctx>, StaticProgramError> {
         let pre_compute: &mut ModularIsEqualPreCompute<TOTAL_READ_SIZE> = data.borrow_mut();
-
         let is_setup = self.pre_compute_impl(pc, inst, pre_compute)?;
-        let fn_ptr = if is_setup {
-            execute_e1_impl::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, true>
-        } else {
-            execute_e1_impl::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, false>
-        };
 
-        Ok(fn_ptr)
+        dispatch!(execute_e1_impl, is_setup)
     }
 
     #[cfg(feature = "tco")]
@@ -562,15 +566,9 @@ where
         Ctx: ExecutionCtxTrait,
     {
         let pre_compute: &mut ModularIsEqualPreCompute<TOTAL_READ_SIZE> = data.borrow_mut();
-
         let is_setup = self.pre_compute_impl(pc, inst, pre_compute)?;
-        let fn_ptr = if is_setup {
-            execute_e1_tco_handler::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, true>
-        } else {
-            execute_e1_tco_handler::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, false>
-        };
 
-        Ok(fn_ptr)
+        dispatch!(execute_e1_tco_handler, is_setup)
     }
 }
 
@@ -596,13 +594,24 @@ where
         pre_compute.chip_idx = chip_idx as u32;
 
         let is_setup = self.pre_compute_impl(pc, inst, &mut pre_compute.data)?;
-        let fn_ptr = if is_setup {
-            execute_e2_impl::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, true>
-        } else {
-            execute_e2_impl::<_, _, NUM_LANES, LANE_SIZE, TOTAL_READ_SIZE, false>
-        };
 
-        Ok(fn_ptr)
+        dispatch!(execute_e2_impl, is_setup)
+    }
+
+    fn metered_handler<Ctx: MeteredExecutionCtxTrait>(
+        &self,
+        chip_idx: usize,
+        pc: u32,
+        inst: &Instruction<F>,
+        data: &mut [u8],
+    ) -> Result<Handler<F, Ctx>, StaticProgramError> {
+        let pre_compute: &mut E2PreCompute<ModularIsEqualPreCompute<TOTAL_READ_SIZE>> =
+            data.borrow_mut();
+        pre_compute.chip_idx = chip_idx as u32;
+
+        let is_setup = self.pre_compute_impl(pc, inst, &mut pre_compute.data)?;
+
+        dispatch!(execute_e2_tco_handler, is_setup)
     }
 }
 
@@ -626,6 +635,7 @@ unsafe fn execute_e1_impl<
     );
 }
 
+#[create_tco_handler]
 unsafe fn execute_e2_impl<
     F: PrimeField32,
     CTX: MeteredExecutionCtxTrait,