update moving prices outside of coinbase

Author: camfairchild

pallets/subtensor/src/coinbase/block_step.rs

@@ -21,12 +21,15 @@ impl<T: Config + pallet_drand::Config> Pallet<T> {
 
         // --- 3. Reveal matured weights.
         Self::reveal_crv3_commits();
+        // --- 4. Run emission through network.
         Self::run_coinbase(block_emission);
-        // --- 4. Set pending children on the epoch; but only after the coinbase has been run.
+        // --- 5. Update moving prices AFTER using them for emissions.
+        Self::update_moving_prices();
+        // --- 6. Set pending children on the epoch; but only after the coinbase has been run.
         Self::try_set_pending_children(block_number);
-        // --- 5. Run auto-claim root divs.
+        // --- 7. Run auto-claim root divs.
         Self::run_auto_claim_root_divs(last_block_hash);
-        // --- 6. Populate root coldkey maps.
+        // --- 8. Populate root coldkey maps.
         Self::populate_root_coldkey_staking_maps();
 
         // Return ok.
@@ -264,6 +267,16 @@ impl<T: Config + pallet_drand::Config> Pallet<T> {
         }
     }
 
+    pub fn update_moving_prices() {
+        let subnets_to_emit_to: Vec<NetUid> =
+            Self::get_subnets_to_emit_to(&Self::get_all_subnet_netuids());
+        // Only update price EMA for subnets that we emit to.
+        for netuid_i in subnets_to_emit_to.iter() {
+            // Update moving prices after using them above.
+            Self::update_moving_price(*netuid_i);
+        }
+    }
+
     pub fn reveal_crv3_commits() {
         let netuids: Vec<NetUid> = Self::get_all_subnet_netuids();
         for netuid in netuids.into_iter().filter(|netuid| *netuid != NetUid::ROOT) {

pallets/subtensor/src/coinbase/run_coinbase.rs

@@ -215,15 +215,8 @@ impl<T: Config> Pallet<T> {
                 *total = total.saturating_add(tou64!(pending_alpha).into());
             });
         }
-
-        // --- 7. Update moving prices after using them in the emission calculation.
-        // Only update price EMA for subnets that we emit to.
-        for netuid_i in subnets_to_emit_to.iter() {
-            // Update moving prices after using them above.
-            Self::update_moving_price(*netuid_i);
-        }
-
-        // --- 8. Drain pending emission through the subnet based on tempo.
+    
+        // --- Drain pending emissions for all subnets hat are at their tempo.
         // Run the epoch for *all* subnets, even if we don't emit anything.
         for &netuid in subnets.iter() {