Fix DefaultFlowEmaSmoothingFactor (should be i64 normalized)

Author: gztensor

pallets/subtensor/src/coinbase/subnet_emissions.rs

@@ -59,7 +59,7 @@ impl<T: Config> Pallet<T> {
             // EMA flow already initialized
             if last_block != current_block {
                 let flow_alpha = I64F64::saturating_from_num(FlowEmaSmoothingFactor::<T>::get())
-                    .safe_div(I64F64::saturating_from_num(u64::MAX));
+                    .safe_div(I64F64::saturating_from_num(i64::MAX));
                 let one = I64F64::saturating_from_num(1);
                 let ema_flow = (one.saturating_sub(flow_alpha))
                     .saturating_mul(last_block_ema)

pallets/subtensor/src/lib.rs

@@ -1302,10 +1302,10 @@ pub mod pallet {
     /// Default value for flow EMA smoothing.
     pub fn DefaultFlowEmaSmoothingFactor<T: Config>() -> u64 {
         // Example values:
-        //   half-life            factor value        u64 normalized
-        //   216000 (1 month) --> 0.000003209009576 ( 59_195_778_378_555)
-        //    50400 (1 week)  --> 0.000013752825678 (253_694_855_576_670)
-        59_195_778_378_555
+        //   half-life            factor value        i64 normalized
+        //   216000 (1 month) --> 0.000003209009576 ( 29_597_889_189_277)
+        //    50400 (1 week)  --> 0.000013752825678 (126_847_427_788_335)
+        29_597_889_189_277
     }
     #[pallet::type_value]
     /// Flow EMA smoothing half-life.