clippy

Author: JohnReedV

pallets/subtensor/src/migrations/migrate_kappa_map_to_default.rs

@@ -5,20 +5,18 @@ use scale_info::prelude::string::String;
 
 pub fn migrate_kappa_map_to_default<T: Config>() -> Weight {
     let mig_name: Vec<u8> = b"kappa_map_to_default".to_vec();
+    let mig_name_str = String::from_utf8_lossy(&mig_name);
 
     // 1 read for the HasMigrationRun flag
     let mut total_weight = T::DbWeight::get().reads(1);
 
     // Run once guard
     if HasMigrationRun::<T>::get(&mig_name) {
-        log::info!(
-            "Migration '{}' already executed - skipping",
-            String::from_utf8_lossy(&mig_name)
-        );
+        log::info!("Migration '{mig_name_str}' already executed - skipping");
         return total_weight;
     }
 
-    log::info!("Running migration '{}'", String::from_utf8_lossy(&mig_name));
+    log::info!("Running migration '{mig_name_str}'");
 
     let target: u16 = DefaultKappa::<T>::get();
 
@@ -29,32 +27,28 @@ pub fn migrate_kappa_map_to_default<T: Config>() -> Weight {
     let mut unchanged: u64 = 0;
 
     for (netuid, current) in Kappa::<T>::iter() {
-        visited += 1;
-        reads += 1;
+        visited = visited.saturating_add(1);
+        reads = reads.saturating_add(1);
 
         if current != target {
             Kappa::<T>::insert(netuid, target);
-            writes += 1;
-            updated += 1;
+            writes = writes.saturating_add(1);
+            updated = updated.saturating_add(1);
         } else {
-            unchanged += 1;
+            unchanged = unchanged.saturating_add(1);
         }
     }
 
     total_weight = total_weight.saturating_add(T::DbWeight::get().reads_writes(reads, writes));
 
     log::info!(
-        "Kappa migration summary: visited={visited}, updated={updated}, unchanged={unchanged}, target_default={}",
-        target
+        "Kappa migration summary: visited={visited}, updated={updated}, unchanged={unchanged}, target_default={target}"
     );
 
     HasMigrationRun::<T>::insert(&mig_name, true);
     total_weight = total_weight.saturating_add(T::DbWeight::get().writes(1));
 
-    log::info!(
-        "Migration '{}' completed",
-        String::from_utf8_lossy(&mig_name)
-    );
+    log::info!("Migration '{mig_name_str}' completed");
 
     total_weight
 }

pallets/subtensor/src/tests/migration.rs

@@ -2179,33 +2179,37 @@ fn test_migrate_kappa_map_to_default() {
         // 0. Constants / helpers
         // ------------------------------
         const MIG_NAME: &[u8] = b"kappa_map_to_default";
-
         let default: u16 = DefaultKappa::<Test>::get();
-        let not_default: u16 = default.wrapping_add(1);
+
+        let not_default: u16 = if default == u16::MAX {
+            default.saturating_sub(1)
+        } else {
+            default.saturating_add(1)
+        };
 
         // ------------------------------
-        // 1. Pre-state: seed non-default & default entries
+        // 1. Pre-state: seed using the correct key type (NetUid)
         // ------------------------------
         let n0: NetUid = 0u16.into();
         let n1: NetUid = 1u16.into();
         let n2: NetUid = 42u16.into();
 
-        Kappa::<Test>::insert(&n0, not_default);
-        Kappa::<Test>::insert(&n1, default);
-        Kappa::<Test>::insert(&n2, not_default);
+        Kappa::<Test>::insert(n0, not_default);
+        Kappa::<Test>::insert(n1, default);
+        Kappa::<Test>::insert(n2, not_default);
 
         assert_eq!(
-            Kappa::<Test>::get(&n0),
+            Kappa::<Test>::get(n0),
             not_default,
             "precondition failed: Kappa[n0] should be non-default before migration"
         );
         assert_eq!(
-            Kappa::<Test>::get(&n1),
+            Kappa::<Test>::get(n1),
             default,
             "precondition failed: Kappa[n1] should be default before migration"
         );
         assert_eq!(
-            Kappa::<Test>::get(&n2),
+            Kappa::<Test>::get(n2),
             not_default,
             "precondition failed: Kappa[n2] should be non-default before migration"
         );
@@ -2231,17 +2235,17 @@ fn test_migrate_kappa_map_to_default() {
         );
 
         assert_eq!(
-            Kappa::<Test>::get(&n0),
+            Kappa::<Test>::get(n0),
             default,
             "Kappa[n0] should be reset to the configured default"
         );
         assert_eq!(
-            Kappa::<Test>::get(&n1),
+            Kappa::<Test>::get(n1),
             default,
             "Kappa[n1] should remain at the configured default"
         );
         assert_eq!(
-            Kappa::<Test>::get(&n2),
+            Kappa::<Test>::get(n2),
             default,
             "Kappa[n2] should be reset to the configured default"
         );